From dbf67484575584a20adf4e63fa7f484fea943fd5 Mon Sep 17 00:00:00 2001
From: cardillan <122014763+cardillan@users.noreply.github.com>
Date: Sat, 7 Dec 2024 15:27:43 +0100
Subject: [PATCH] Fixes #183: Using the basic optimizations can also cause
 problems with the output

---
 .../generator/LogicInstructionGenerator.java  |  1 +
 .../optimization/FunctionInlinerTest.java     | 22 +++++++++++++++++++
 2 files changed, 23 insertions(+)

diff --git a/compiler/src/main/java/info/teksol/mindcode/compiler/generator/LogicInstructionGenerator.java b/compiler/src/main/java/info/teksol/mindcode/compiler/generator/LogicInstructionGenerator.java
index 2e48c3e2f..b9685c3c8 100644
--- a/compiler/src/main/java/info/teksol/mindcode/compiler/generator/LogicInstructionGenerator.java
+++ b/compiler/src/main/java/info/teksol/mindcode/compiler/generator/LogicInstructionGenerator.java
@@ -705,6 +705,7 @@ private LogicValue handleStacklessFunctionCall(LogicFunction function, List<Logi
         //      Use GOTO_OFFSET for list iterator, drop marker from GOTO and target simple labels
         emit(createGotoLabel(returnLabel, LogicLabel.symbolic(functionPrefix)));
 
+        setSubcontextType(function, AstSubcontextType.PARAMETERS);
         retrieveFunctionParameters(function, arguments, false);
         return passReturnValue(function);
     }
diff --git a/compiler/src/test/java/info/teksol/mindcode/compiler/optimization/FunctionInlinerTest.java b/compiler/src/test/java/info/teksol/mindcode/compiler/optimization/FunctionInlinerTest.java
index e107ab2cc..3e88e545f 100644
--- a/compiler/src/test/java/info/teksol/mindcode/compiler/optimization/FunctionInlinerTest.java
+++ b/compiler/src/test/java/info/teksol/mindcode/compiler/optimization/FunctionInlinerTest.java
@@ -39,6 +39,28 @@ def foo(n)
         );
     }
 
+    @Test
+    void inlinesFunctionWithOutputParameter() {
+        assertCompilesTo("""
+                        param c = 10;
+                        void foo(a, out b)
+                            b = c * a;
+                        end;
+                        
+                        foo(10, out x);
+                        foo(20, out y);
+                        
+                        print(x, y);
+                        """,
+                createInstruction(SET, "c", "10"),
+                createInstruction(OP, "mul", "__fn0_b", "c", "10"),
+                createInstruction(SET, "x", "__fn0_b"),
+                createInstruction(OP, "mul", "__fn0_b", "c", "20"),
+                createInstruction(PRINT, "x"),
+                createInstruction(PRINT, "__fn0_b")
+        );
+    }
+
     @Test
     void inlinesTwoFunction() {
         assertCompilesTo("""