Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creation of end date for rollover membership #2614

Open
maneesha opened this issue Feb 13, 2024 · 1 comment
Open

Fix creation of end date for rollover membership #2614

maneesha opened this issue Feb 13, 2024 · 1 comment

Comments

@maneesha
Copy link
Contributor

When we rollover a membership, we typically want the new membership to start the day after the source membership ends, and end a year after the new membership begins.

In the function to create the rollover membership, we successfully set the start date. However, because of the way the end date is calculated, we end up with an error in leap years. For example, a membership that started 2023-03-01 would end 2024-02-29. A rollover membership should start 2024-03-01 and end 2025-02-28. The current code tries to create the invalid date of 2025-02-29.

The recommended change is that the new end date should be the new start date plus one year, not the start year plus one.

@maneesha
Copy link
Contributor Author

Marking this as medium priority because it is a bug and relatively easy to fix but also won't matter again until 2028.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To do - Medium Priority
Development

No branches or pull requests

1 participant