Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2020-12-16: Order of Languages in homepage #259

Closed
TomKellyGenetics opened this issue Dec 16, 2020 · 3 comments
Closed

2020-12-16: Order of Languages in homepage #259

TomKellyGenetics opened this issue Dec 16, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@TomKellyGenetics
Copy link
Contributor

TomKellyGenetics commented Dec 16, 2020

Regarding the order of the entries (#254), the languages on the homepage may need to be changed for consistency (this is done manually as I understand it).

In PR #129 I added Japanese but it is under Portuguese by mistake (not sure if this was changed around the same time and merged awkwardly).

https://github.com/carpentries/glosario/blob/3ddacca7561222220af08c910b10b1a7981c1635/_config.yml#L114_L127

I wasn't sure whether to sort alphabetically by roman letters (e.g. de, en, fr, it, ja, nl, pt) or use romansied names 日本語(Nihongo) as discussed here or sort by language name in endonyms as done here with other alphabets, abjad, and CJK characters at the end:

Endonym Romanised English name ISO 639-1 ISO 639-2
Afrikaans af afr
Català Catalan ca cat
Deutsch German de deu
English en eng
Español Spanish es span
Français French fr fra
Nederlands Dutch nl nld
Polski Polish po pol
Ελληνικά Elliniká Greek el gre
עִבְרִית‎ Ivrit Hebrew he heb
Русский язык rússkiy yazýk Russian ru rus
العربية al-ʿarabiyyah Arabic ar ara
हिन्दी Hindī hi hin
ภาษาไทย Phasa Thai Thai th tha
한국어 Hangug-eo Korean ko kor
简体中文 Jiǎntǐ Zhōngwén Chinese (simplified) zh_ch chi
繁體中文 Fántǐ Zhōngwén Chinese (traditional) zh_tw zh_hk zho
日本語 Nihongo Japanese ja jpn

So either we sort Japanese as "ja", "nihongo", or put it at the end as a special character (in which case Arabic would be moved as well).

@baileythegreen
Copy link
Contributor

The order of languages on the homepage is not ever sorted. It is determined entirely by the order of the entries in _config.yml. If you look, you will see that Japanese in this file is below Portuguese.

I gather that the number of languages that exist in this project has grown fairly quickly. Before it gets out-of-hand, we should consider whether it makes sense to have a home page that lists all of the languages and their respective blurbs in some order, or:

  1. either detect the language settings of the computer/browser as this post asks (not something I know how to do at the moment, but I can learn which variables to use), or
  2. just have a dropdown menu where people can choose their language, as many sites do. I don't see the mechanics and CSS for that being terribly difficult.

@TomKellyGenetics
Copy link
Contributor Author

The order of languages on the homepage is not ever sorted. It is determined entirely by the order of the entries in _config.yml. If you look, you will see that Japanese in this file is below Portuguese.

I understand that, I'm suggesting to decide on a consistent order to manually change it (as it only needs to be done once) and make sure that new languages are added correctly. The problem seems to be non-Latin writing systems as it's not clear where to sort them.

Of course if either of your suggested solutions are implemented this would be no longer relevant. They're both good ideas but I actually like the home page giving an overview of how many languages are supported as it is.

@ian-flores
Copy link
Member

Fixed in #260

TomKellyGenetics added a commit to swcarpentry-ja/glosario that referenced this issue Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants