-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2024-06-24]: [Alphabetical ordering for Ukrainian and Portuguese languages] #724
Comments
It seems to me the issue is not with the navigation bar, but with terms being ordered in the wrong way in the first instance. I have traced this to "Find terms defined in this language and sort alphabetically": but I don't know where to go from here. |
Could it be because we don't have all letters for all terms? So it just ordered ones that only exist |
@YehorBoiar we can of course try to push for more translations to cover more Ukrainian letters - new PRs welcome :) But I don't think that "І" at the last place depends somehow on that. That is perhaps due to Unicode codes playing the role. Similar problem for Portuguese in https://glosario.carpentries.org/pt/ where  is not after A, but at the very end. I don't have any knowledge of Portuguese to comment on this, but https://portuguese.stackexchange.com/questions/5797/do-diacritical-marks-accents-affect-alphabetical-sorting-of-words suggests that this is not the way it should be. |
P.S. Indeed the unicode code seems to be relevant: compare Ukrainian alphabet by position in alphabet at https://en.wikipedia.org/wiki/Ukrainian_alphabet with the Ukrainian character table at https://character-table.netlify.app/ukrainian/. So the question is as before - how to introduce sorting in a properly alphabetical order? |
This will be down to how liquid and jekyll implement their It seems that they sort by unicode rather than natural ordering in that specific language: Relevant other info: |
Related to #254 |
Would it be possible to provide correct sorting for each language explicitly (and request providing that as a part of adding new languages)? |
I believe I've implemented this correctly in the PR above, but due to my lack of lingual knowledge of many of the languages we have in the glossary, it's hard for me to verify! @olexandr-konovalov has been kind enough to verify the Ukrainian sorting as correct. Remaining issues:
|
Excellent - thanks @froggleston! |
The right navigation bar with letters at https://glosario.carpentries.org/uk/ does not follow the order of letters in Ukrainian alphabet, placing "І" at the last place. Is there a way to enforce the fixed order of the letters?
The text was updated successfully, but these errors were encountered: