Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation website images are not rendering #278

Open
tracykteal opened this issue Apr 29, 2022 · 4 comments
Open

Documentation website images are not rendering #278

tracykteal opened this issue Apr 29, 2022 · 4 comments

Comments

@tracykteal
Copy link

It looks like the images on https://carpentries.github.io/sandpaper/ aren't rendering
@zkamvar
Copy link
Contributor

zkamvar commented Apr 29, 2022

🤦🏼 I think this is a {pkgdown} idiomatic thing. The images are in vignettes/articles/img, which works for the GitHub README, but does not work for the landing page because of a missed redirect from https://carpentries.github.io/sandpaper/articles/articles/img/branch-flow.svg to https://carpentries.github.io/sandpaper/articles/img/branch-flow.svg

@zkamvar
Copy link
Contributor

zkamvar commented Apr 29, 2022

Thank you for letting me know about it! I'll try to get it fixed soon!

@tracykteal
Copy link
Author

Awesome! Just thought I'd flag.

@zkamvar zkamvar changed the title Image rendering Documentation website images are not rendering Apr 29, 2022
@vinisalazar
Copy link

@froggleston reviving this issue as this problem is still ongoing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tracykteal @zkamvar @vinisalazar