German language support not working ..

[martin-raden]

Hi @froggleston

thanks for the fast integration of the German translation into release 0.16.8.

Unfortunately, it is not working in my Carpentry Tutorial ... 😢

lang: de

https://github.com/Dr-Eberle-Zentrum/FDM-basics/blob/d81fd8c90ae4a00a2ff3309a54016df589083593/config.yaml#L22

uses the English fallback... see build output at... (which references the recent sandpaper version in the footer)

https://dr-eberle-zentrum.github.io/FDM-basics/

Switching to lang: uk works...

Any ideas here?

Thanks,
Martin

[martin-raden]

it seems the inst/po folder doesnt feature the de data ... ie. no .mo file was created ..

[martin-raden]

Maybe missed this?

sandpaper/vignettes/translations.Rmd

Line 180 in d566621

### Updates to translations

[froggleston]

Hi @martin-raden - yes this is correct and an oversight on my part so sorry for missing this!

I have built the translation files and committed them, so you should be able to build your lessons locally with the main branch. In an upcoming release it will be included properly.

[martin-raden]

👍

[froggleston]

This should now be fixed in 0.16.9, released just now!

[martin-raden]

Many thanks! I just tested and it worked like a charm! 👍