Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ModelRaw for python API #10

Open
carrascomj opened this issue Nov 14, 2020 · 0 comments
Open

Use ModelRaw for python API #10

carrascomj opened this issue Nov 14, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@carrascomj
Copy link
Owner

There is not a very good reason to use Model instead of ModelRaw for the python bindings (at pyo.rs).

  • Drawback: getParameter would be O(n) (or better, whatever find is) instead of O(1), but that can be solved easily, if needed (not really, the usual number of parameters in SBML documents do not justify the use of a more complex data structure in this case).
  • Advantage: using ModelRaw would allow for adding writing capabilities to the python API.
  • Advantage: less String allocations.
@carrascomj carrascomj added enhancement New feature or request good first issue Good for newcomers labels Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant