Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tag constraints when adding a package repo with kctrl #1455

Closed
tomkennedy513 opened this issue Jan 22, 2024 · 1 comment · Fixed by #1471
Closed

Add support for tag constraints when adding a package repo with kctrl #1455

tomkennedy513 opened this issue Jan 22, 2024 · 1 comment · Fixed by #1471
Assignees
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@tomkennedy513
Copy link

Describe the problem/challenge you have

I am trying to add a package repo using kctrl package repository add and I would like to make use of the .spec.fetch.imgpkgBundle.tagSelection.semver.constraints field available on the PackageRepository CRD.

Describe the solution you'd like

I would like to be able to do something like kctrl package repository add my-repo --url my-repo-without-passing-in-a-tag --semver-tag-constraints "1.8.x" which would generate something like this:

apiVersion: packaging.carvel.dev/v1alpha1
kind: PackageRepository
metadata:
  name: my-repo
spec:
  fetch:
    imgpkgBundle:
      image: my-repo-without-passing-in-a-tag
      tagSelection:
        semver:
          constraints: "1.8.x"

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@tomkennedy513 tomkennedy513 added carvel-triage This issue has not yet been reviewed for validity enhancement This issue is a feature request labels Jan 22, 2024
@praveenrewar praveenrewar added carvel-accepted This issue should be considered for future work and that the triage process has been completed and removed carvel-triage This issue has not yet been reviewed for validity labels Jan 24, 2024
@renuy renuy added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jan 29, 2024
@rohitagg2020
Copy link
Contributor

We need to also be careful that we are not accepting the tag and semver at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants