Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json schema for vendir spec #288

Open
gberche-orange opened this issue Aug 30, 2023 · 2 comments
Open

Json schema for vendir spec #288

gberche-orange opened this issue Aug 30, 2023 · 2 comments
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request good first issue An issue that will be a good candidate for a new contributor hacktoberfest Hacktoberfest issue

Comments

@gberche-orange
Copy link

Describe the problem/challenge you have

It would be convenient to have coding assistance from IDE when reading/editing a vendir.yaml file

Describe the solution you'd like

Formatting the https://carvel.dev/vendir/docs/v0.34.x/vendir-spec/ as a https://json-schema.org/ and registering it into https://www.schemastore.org/json/ would automatically enable most recent IDEs (e.g. intellij, vscode) to automatically provide:

  • inline doc
  • completion
  • static analysis

Anything else you would like to add:
[Additional information that will assist in solving the issue.]


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@gberche-orange gberche-orange added carvel-triage This issue has not yet been reviewed for validity enhancement This issue is a feature request labels Aug 30, 2023
@kumaritanushree
Copy link
Contributor

@gberche-orange Thank you for raising this request. Sounds good to have this.

@joaopapereira
Copy link
Member

Going to accept this issue.
We can add this directly into schemastore or host it in carvel.dev. My first inclination would be to host it in carvel.dev and just register that URL.

Another thing that could be interesting is to find a way to do this automatically. I saw there are a couple of libraries that generate the jsonschema directly from go structs maybe that is something that can be explored, we might need to add some docs on our structs to help with this but apart from that, it should be pretty simple.

In the first iteration, we can just add the schema manually, but it would be great if we find a way to do this automatically with our release process.

@joaopapereira joaopapereira added good first issue An issue that will be a good candidate for a new contributor carvel-accepted This issue should be considered for future work and that the triage process has been completed hacktoberfest Hacktoberfest issue and removed carvel-triage This issue has not yet been reviewed for validity labels Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request good first issue An issue that will be a good candidate for a new contributor hacktoberfest Hacktoberfest issue
Projects
Status: No status
Development

No branches or pull requests

3 participants