Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dangerousSkipTLSVerify option when fetching from http server. #292

Open
GrahamDumpleton opened this issue Sep 20, 2023 · 2 comments
Assignees
Labels
enhancement This issue is a feature request

Comments

@GrahamDumpleton
Copy link

Describe the problem/challenge you have

I need to use vendir to download files from a web server but the web server uses self signed certificates. This will fail as vendir will verify certificates when using http. Docs do not give an example to say can disable this check so assume you can't.

Describe the solution you'd like

Add dangerousSkipTLSVerify option to http section.

    http:
      # asset URL (required)
      url: 
      # verification checksum (optional)
      sha256: ""
      # specifies name of a secret with basic auth details;
      # secret may include 'username', 'password' keys (optional)
      secretRef:
        # (required)
        name: my-http-auth
      # skip unpacking tar, tgz, and zip files; by default files are unpacked (optional)
      disableUnpack: false

      # specify wether to skip TLS verification; defaults to false
      dangerousSkipTLSVerify: false

Anything else you would like to add:

Should also be added to kapp-controller to keep parity.


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@GrahamDumpleton GrahamDumpleton added carvel-triage This issue has not yet been reviewed for validity enhancement This issue is a feature request labels Sep 20, 2023
@GrahamDumpleton GrahamDumpleton changed the title Support dangerouSkipTLSVerify option when fetching from http server. Support dangerousSkipTLSVerify option when fetching from http server. Sep 20, 2023
@vmunishwar
Copy link
Contributor

@GrahamDumpleton - Thanks for reporting the issue. We have a similar issue earlier reported. I guess these are requesting the same changes. Could you please confirm?

@vmunishwar vmunishwar removed the carvel-triage This issue has not yet been reviewed for validity label Sep 21, 2023
@vmunishwar vmunishwar self-assigned this Sep 21, 2023
@GrahamDumpleton
Copy link
Author

Similar but not the same. The other one is for git fetch, not http fetch. So different parts of code and for different functionality in vendir.

@vmunishwar vmunishwar assigned vmunishwar and unassigned vmunishwar Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue is a feature request
Projects
Status: No status
Development

No branches or pull requests

2 participants