[3.6.1] CMake doesn't find casacore libraries on Debian

[olebole]

I am currently working to upgrade the Debian package of python-casacore to 3.6.1, which comes with a new, CMake supported build system. The problem I found here is that on Debian,

• the header files of casacore are placed in /usr/lib/include/casacore/
• the library files (symlinks) are in /usr/lib/x86_64-linux-gnu/

See https://packages.debian.org/sid/amd64/casacore-dev/filelist for the list of files in the development package.

From

python-casacore/cmake/FindCasacore.cmake

Lines 18 to 21 in db14e98

	# Variables used by this module:
	# CASACORE_ROOT_DIR - Casacore root directory.
	# BLAS_LIBS - override BLAS library
	# LAPACK_LIBS - override LAPACK library

one can only set a common variable for both includes and headers, which would not work here.

The wcslib and cfitsio packages however (which have a similar structure) are found; so maybe one could re-use a bit this way here as well. Also BLAS and LAPACK.

[tammojan]

Thanks for packaging! The FindCasacore.cmake module indeed could use modernization. But somehow, for me this just works, on a fresh debian sid with your casacore-dev 3.6.1, with the master of python-casacore:

apt update
apt install -y casacore-dev
apt remove -y python3-casacore
apt install -y git build-essential vim python3-venv
cd
git clone https://github.com/casacore/python-casacore
cd python-casacore/
python3 -m venv venv
source venv/bin/activate
apt install -y wcslib-dev libcfitsio-dev libblas-dev liblapack-dev libboost-python-dev
pip install .

[gmloose]

I'm also a bit confused. If I follow the link https://packages.debian.org/sid/amd64/casacore-dev/filelist, I see a list of header files in /usr/include, right where you'd expect them, not in /usr/lib/include. If python-casacore fails to find casacore, it may help to set CMAKE_PREFIX_PATH to the install directory of casacore. That, however, should not be necessary if casacore is installed in one of the system default paths.