Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify.py "Match!" emission problematic #3

Open
ajnelson-nist opened this issue Apr 9, 2018 · 3 comments
Open

verify.py "Match!" emission problematic #3

ajnelson-nist opened this issue Apr 9, 2018 · 3 comments

Comments

@ajnelson-nist
Copy link
Member

The verifier.py script outputs "Match!" lines for good records. I think this is low-utility information, and possibly counter-productive. If a file is overwhelmingly good records, there are two problems:

  • Any problematic records of small inputs being visually inspected can get lost without filtering.
  • The processing time spent writing "Match!" to screen or log output is significant, and for a large-enough file (say, the 42 MB Plaso sample mft.xml), basically punishes the verification-runner for checking data.

I propose "Match!" not be emitted, except maybe in a "verbose" mode.

@jstroud-mitre
Copy link
Contributor

@ajnelson-nist , this is a great point. I will close this when I update the verifier.py with said functionality. Stay tuned.

@jstroud-mitre
Copy link
Contributor

When you have a moment, please download minify-branch and see if it fixes this issue along with issue-1 and issue-2

@ajnelson-nist
Copy link
Member Author

Menial matter:
TabError: inconsistent use of tabs and spaces in indentation

After correcting that whitespace matter, I think the --verbose flag resolves this Issue. I'll comment on the other issues in their threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants