Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanups #2762

Closed
piotr-dziubecki opened this issue Mar 18, 2022 · 3 comments
Closed

Minor cleanups #2762

piotr-dziubecki opened this issue Mar 18, 2022 · 3 comments

Comments

@piotr-dziubecki
Copy link

piotr-dziubecki commented Mar 18, 2022

  • replace all .../CasperLabs/casper-node URLs with .../casper-network/casper-node
  • remove
    • build_wasm_package.sh
    • docker_make.sh
    • joiner-dev-tmux.sh
    • run-dev-tmux.sh
    • stop-dev.sh
    • update-rev.sh
    • upload.sh
  • avoid using #[serde(with = "HexForm")] in ExecutableDeployItem::ModuleBytes::module_bytes (we can remove the dependency entirely)
  • feature-gate CorrelationId::is_empty() via #[cfg(test)]
@devendran-m
Copy link
Contributor

Triaged;

  • replace all .../CasperLabs/casper-node URLs with .../casper-network/casper-node - Still some references are there. Needs cleaning up.
  • remove - Done
    • build_wasm_package.sh
    • docker_make.sh
    • joiner-dev-tmux.sh
    • run-dev-tmux.sh
    • stop-dev.sh
    • update-rev.sh
    • upload.sh
  • avoid using #[serde(with = "HexForm")] in ExecutableDeployItem::ModuleBytes::module_bytes (we can remove the dependency entirely) - Done
  • feature-gate CorrelationId::is_empty() via #[cfg(test)] - Removed

@devendran-m
Copy link
Contributor

Triage update - Create new ticket for "replace all .../CasperLabs/casper-node URLs with .../casper-network/casper-node" and close this ticket.

@devendran-m
Copy link
Contributor

New ticket created to replace incorrect URLs - #4902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants