Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minimum bid amount from 1.5.8 #4834

Open
SaiProServ opened this issue Aug 21, 2024 · 1 comment
Open

Add minimum bid amount from 1.5.8 #4834

SaiProServ opened this issue Aug 21, 2024 · 1 comment
Assignees
@darthsiroftardis
Labels
rc-5 Release Candidate 5

Comments

@SaiProServ
Copy link

We need to add the changes for minimum bid amount to feat-2.0 from 1.5.8
@sacherjj
Copy link
Contributor

@darthsiroftardis
This should include changes from PR 162 and 163 from private repo.

@devendran-m devendran-m added the rc-5 Release Candidate 5 label Sep 13, 2024
@darthsiroftardis darthsiroftardis mentioned this issue Oct 7, 2024
Merged
casperlabs-bors-ng bot added a commit that referenced this issue Oct 14, 2024
@casperlabs-bors-ng @darthsiroftardis
Merge #4910
d447806 
4910: Add minimum bid amount to add and withdraw bid r=EdHastingsCasperAssociation a=darthsiroftardis

CHANGELOG:

- Added `minimum_bid_amount` to core config in chainspec which specifies the minimum bid amount in motes
- Changed `add_bid` function to return error if the staked amount is under the minimum amount
- Changed `withdraw_bid` function to completely unbond a validator is their updated stake drops to strictly less than the min bid amount
- Changed `add_bid` from u32 to u64

Closes #4834 



Co-authored-by: Karan Dhareshwar <[email protected]>
casperlabs-bors-ng bot added a commit that referenced this issue Oct 17, 2024
@casperlabs-bors-ng @darthsiroftardis
Merge #4910
ce03bbf 
4910: Add minimum bid amount to add and withdraw bid r=darthsiroftardis a=darthsiroftardis

CHANGELOG:

- Added `minimum_bid_amount` to core config in chainspec which specifies the minimum bid amount in motes
- Changed `add_bid` function to return error if the staked amount is under the minimum amount
- Changed `withdraw_bid` function to completely unbond a validator is their updated stake drops to strictly less than the min bid amount
- Changed `add_bid` from u32 to u64

Closes #4834 



Co-authored-by: Karan Dhareshwar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darthsiroftardis darthsiroftardis

Labels
rc-5 Release Candidate 5
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sacherjj @devendran-m @darthsiroftardis @rafal-ch @SaiProServ