Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"validators_disconnect.sh" NCTL test passes correctly with Highway, but fails with Zug #4837

Open
SaiProServ opened this issue Aug 27, 2024 · 3 comments
Assignees
Labels
bug Something isn't working rc-5 Release Candidate 5

Comments

@SaiProServ
Copy link

When Zug is enabled, network fails to resume operation after the previously disabled validators are started again

@devendran-m devendran-m added bug Something isn't working rc-5 Release Candidate 5 labels Sep 17, 2024
@devendran-m
Copy link
Contributor

Follow-up point from L1 Daily on 17-Sep-24;

  • Determine how much work remains to be done for the protocol state persistence.

@devendran-m
Copy link
Contributor

devendran-m commented Sep 19, 2024

Update from Bart in the L1 Daily on 18-Sep-24;

Regarding the persistence of consensus state - what Zug persists isn't really the state, but it should be sufficient for resuming operation AFAICT. For Highway, the effort depends slightly on where we would want to store the state - storage, or some additional files similar to currently used unit files? Storage would be slightly more effort, but with it now being available in other components as an object (and not just through events/effects) it should not be too hard, either.

Action: As outlined by Ed, Bart should describe the state that needs to be persistent and define when it should be persistent. This detailed specification will allow the task to be delegated to other team members for implementation.

@fizyk20
Copy link
Collaborator

fizyk20 commented Sep 19, 2024

@devendran-m Those updates would fit #3904 better than this ticket, I think. This one is about a failing test and likely completely unrelated to the persistence of protocol state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rc-5 Release Candidate 5
Projects
None yet
Development

No branches or pull requests

5 participants