Remove unchecked arithmetic #4907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpapierski
requested review from
darthsiroftardis,
EdHastingsCasperAssociation and
igor-casper
darthsiroftardis
approved these changes
Oct 11, 2024
|
bors r+ |
casperlabs-bors-ng bot
added a commit
that referenced
this pull request
Oct 14, 2024
4907: Remove unchecked arithmetic r=mpapierski a=mpapierski Closes #2103 This PR removes unchecked arithmetic operations. Although nearly impossible this is for correctness reason to avoid using unchecked math even on large numbers. 4911: GH-4164: Update comment r=mpapierski a=mpapierski Closes #4164 Make the chainspec comment clearer Co-authored-by: Michał Papierski <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into feat-2.0. It will not be retried. Additional information: {"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"} |
EdHastingsCasperAssociation
approved these changes
Oct 14, 2024
|
bors r+ |
casperlabs-bors-ng bot
added a commit
that referenced
this pull request
Oct 15, 2024
4907: Remove unchecked arithmetic r=mpapierski a=mpapierski Closes #2103 This PR removes unchecked arithmetic operations. Although nearly impossible this is for correctness reason to avoid using unchecked math even on large numbers. Co-authored-by: Michał Papierski <[email protected]>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
casperlabs-bors-ng
bot
merged commit 874eae2
into
casper-network:feat-2.0
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2103
This PR removes unchecked arithmetic operations. Although nearly impossible this is for correctness reason to avoid using unchecked math even on large numbers.