Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong test assertion #18

Open
davidatwhiletrue opened this issue Jan 8, 2024 · 1 comment
Open

Wrong test assertion #18

davidatwhiletrue opened this issue Jan 8, 2024 · 1 comment

Comments

@davidatwhiletrue
Copy link

davidatwhiletrue commented Jan 8, 2024

The block header proposer key is a validator key, not either the sender or the reciver key of a tranfer.

Therefore, the algo of the proposer key depends on the validator. It cannot be used to assert it the generated key algorithm is ok.

And the returned block header proposer contains the "Secp256k1" algo

Related to this .net SDK issue: make-software/casper-net-sdk#46

@meywood
Copy link
Collaborator

meywood commented Jan 8, 2024

I think that the description of the step is incorrect what this step should be doing is reading the keys bytes and testing the correct algorithm byte is set for Secp256k1. "And the returned block header proposer contains the "Secp256k1" algo" does not really makes sense here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants