Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): ✨ add google analytics #307

Open
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

gchamb
Copy link
Member

@gchamb gchamb commented Jan 16, 2023

  • Initialized Google Analytics
  • Log Sign Up Events for Sign Up Methods
  • Log Lobby Creation
  • Log Lobby Joining
  • Log Games Starting
  • Log Games Ending
  • Log Account Deletions

If there is anything you think would be informative to know that I didn't log then let me know. I'll add it.

@gchamb gchamb linked an issue Jan 16, 2023 that may be closed by this pull request
@gchamb gchamb changed the title feat: ✨ add google analytics feat(client): ✨ add google analytics Jan 16, 2023
@nstringham
Copy link
Member

These all seam like things that could be logged on the server side. Intuitively it seams like logging on the server side would be better because we don't need a bunch of network requests on the user's device.

What do you think?

@gchamb
Copy link
Member Author

gchamb commented Feb 2, 2023

These all seam like things that could be logged on the server side. Intuitively it seams like logging on the server side would be better because we don't need a bunch of network requests on the user's device.

What do you think?

Yeah, we talked about it on the discord. Also, are there any other events we should log that would be meaningful to us?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Google Analytics
2 participants