Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotter colours #14

Open
AnirudhG07 opened this issue Nov 21, 2024 · 13 comments
Open

Spotter colours #14

AnirudhG07 opened this issue Nov 21, 2024 · 13 comments

Comments

@AnirudhG07
Copy link

The recent update has spotter added, please add colors for it in the repository for yazi.
Thanks!

@uncenter
Copy link
Member

The spotter is not included in a release yet, but the repository will be updated for it and everything else new/changed in v0.4 which is expected to come out in ~2 weeks.

@AnirudhG07
Copy link
Author

Yes, alright. Thanks

@AnirudhG07 AnirudhG07 reopened this Dec 9, 2024
@AnirudhG07
Copy link
Author

AnirudhG07 commented Dec 9, 2024

Just a reminder, to please edit the theme for yazi v0.4

@uncenter
Copy link
Member

I've updated the rest, but Yazi itself doesn't support theming the spotter yet: sxyazi/yazi#2002.

@AnirudhG07
Copy link
Author

AnirudhG07 commented Dec 12, 2024

Lol.
Since the spotter follows the default color settings, i think it should? But you must have looked into it, so not doubting u either.
Anyways, thanks for updating the rest!

@uncenter
Copy link
Member

Since the spotter follows the default color settings, i think it should? But you must have looked into it, so not doubting u either.
I don't think it does, I'm not even sure how it is themed if it isn't even in the preset theme files. Anyway, lmk if anything else is unthemed, but I'll get to the spotter as soon as I can after that PR is merged.

@AnirudhG07
Copy link
Author

Alright. I am again closing this issue since I got my answer. Thanks

@AnirudhG07
Copy link
Author

I didnt realise it but the spotter color matches. I donno how. But it works.

image

Maybe the flavours in yazi-rs for cappuccino mocha has something to do with it

@uncenter
Copy link
Member

It doesn't, those are the default theme colors.

@uncenter uncenter reopened this Dec 17, 2024
@AnirudhG07
Copy link
Author

Does your spotter color theme match?

@uncenter
Copy link
Member

No. I believe it's just using my terminal's ANSI blue color, so it looks Catppuccin-y but it isn't themed by this theme actually.

CleanShot 2024-12-17 at 07 41 16

@AnirudhG07
Copy link
Author

I see. still it looks nice mostly.

@xfzv
Copy link

xfzv commented Dec 21, 2024

sxyazi/yazi@5bd71bf added support for border and title

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants