Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote for FP16 PR #68

Open
John1231983 opened this issue Dec 12, 2020 · 3 comments
Open

Vote for FP16 PR #68

John1231983 opened this issue Dec 12, 2020 · 3 comments

Comments

@John1231983
Copy link

Hi all, I am using pytorch 1.16 and it supported FP16. Could your accept the PR ? https://github.com/cavalleria/cavaface.pytorch/pull/32/files
@xsacha please update head file. Thanks
@cavalleria
Copy link
Owner

It support fp16.

@xsacha
Copy link
Contributor

xsacha commented Dec 13, 2020

Yes, I saw that fp16 is in there now and forgot to close my PR. Thanks for heads up.

@John1231983
Copy link
Author

Are you using Apex instead of AMP in pytorch? The method of @xsacha allows us to use AMP, but we should modify something in metric.py as mention.
@xsacha could you update the PR, it is useful for many people, included me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xsacha @cavalleria @John1231983