-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RTL support #4
Comments
Just added an rtl.css file to the in-the-beginning theme. |
Leaving this issue open - see comments on this pull request. |
I am familiar with CSSJanus (and I know Yoav, the developer) but this tool does 80% of the job (at least for Genesis style sheets). Some of the issues that require special attention (and probably need to do them manually):
2.Rules that in the rtl version are composed from different classes - for example - This is not an issue if you are replacing the style.css with a RTLed css but it is an issue if you have the original ltr style sheet and the rtl style sheet (with just the required overrides).
Next week, I am going to have a Skype call with Gary Jones about adding RTL support to genesis, If you wish to join it would be great... Meanwhile, If you know what I should do (instead of what I have done), please advice. Thanks much :) |
Thanks, Nir. I would love to be a fly one the wall for that Skype session. You have a ton more practical experience where RTL is concerned. My hope is to automate where possible so that every LTR-related CSS change doesn't result in a manual update of the RTL styles. Good point also about certain elements pulling styles from multiple classes. If we can improve the original styes to avoid this, by all means, I am open. |
References #4 Added CSSJanus and GruntCSSJanus to auto-update style-rtl.css any time style.css is compiled.
No description provided.
The text was updated successfully, but these errors were encountered: