Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tm90 and tm99 support for Lambda latency monitors #461

Open
stihahi opened this issue Nov 21, 2023 · 1 comment
Open

tm90 and tm99 support for Lambda latency monitors #461

stihahi opened this issue Nov 21, 2023 · 1 comment
Labels
feature-request New feature

Comments

@stihahi
Copy link

stihahi commented Nov 21, 2023

Feature scope

Lambda

Describe your suggested feature

Currently latency alarms supported for LambdaFunctionMonitoring is limited to 3 metrics, P50, P90 and P99.

Our team wants to monitor Lambda latency with TM90 and TM99.

Ref: https://github.com/cdklabs/cdk-monitoring-constructs/blob/main/lib/monitoring/aws-lambda/LambdaFunctionMonitoring.ts#L56-L58

@stihahi stihahi added the feature-request New feature label Nov 21, 2023
@skkrail-amzn
Copy link

It would be helpful if these addLatencyXAlarm props were replaced with a single addLatencyAlarms prop of a type like

Record<string, LatencyThreshold & { statistic: LatencyType }>[]

so we could specify arbitrary latency statistics.

(addLatencyXAlarm is type Record<string, LatencyThreshold>)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature
Projects
None yet
Development

No branches or pull requests

2 participants