Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow_call as workflow trigger #323

Open
webjunkie opened this issue Sep 7, 2022 · 2 comments
Open

Add workflow_call as workflow trigger #323

webjunkie opened this issue Sep 7, 2022 · 2 comments

Comments

@webjunkie
Copy link

I want to run the CDK workflow as a job inside of another workflow. This should be possible by having a trigger workflow_callin the CDK workflow. However, it currently doesn't seem possible to add this via Typescript code.

I don't want to run the CDK workflow on its own, because I want to run e.g. tests first and do other deploy related things afterwards. All in a different existing workflow file which should not be coupled to CDK code.

This issue is also be possibly related to #293 which would allow for such customization I guess.

@kaizencc
Copy link
Contributor

kaizencc commented Sep 22, 2022

Hi @webjunkie! Yes, #293 escape hatching is my no. 1 priority in this module to allow for any such customizations. I'm a bit busy at the moment but I have this feature request ear-marked for when I have a bit of free time.

@kaizencc
Copy link
Contributor

#340 should unblock this request, so I'm marking this as a p2. However, if you're interested in modeling this out in the workflows-model.ts file, I'd be happy to take a contribution. I think its just out of date and we don't have an automated way to keep up to date I don't think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants