Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot tag Cloudformation stack #730

Open
dil-bagoston opened this issue Sep 25, 2023 · 1 comment
Open

Cannot tag Cloudformation stack #730

dil-bagoston opened this issue Sep 25, 2023 · 1 comment

Comments

@dil-bagoston
Copy link

dil-bagoston commented Sep 25, 2023

For my project it would be cool to tag the application stacks` Cloudformation stacks. For certain short-lived envs, we introduce a specific tag, which we would use for our cleanup process. I tried to tag the application stacks as I did for the Codepipeline solution like this:

export class ApplicationStage extends Stage {
  constructor(scope: Construct, id: string, props: ApplicationStageProps) {
    super(scope, id, props);
    const stack = new ApplicationStack(this, 'app', {
      envName: props.envName,
      isDevBranch: props.isDevBranch,
      branchName: props.branchName,
    });
    Object.entries(props.tags).forEach(([key, value]) => {
      Tags.of(stack).add(key, value);
    });
  }
}

For the traditional Codepipeline solution, this solution tags the Cloudformation stack of the application, but unfortunately in GithubActions, this does not set the tags for me.
Could you please help me out with this issue?

@kaizencc
Copy link
Contributor

This is still an experimental module and its quite possible that tagging stacks is broken/not implemented yet. We accept contributions and if there's something we can do here I would be happy to review it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants