From 21c272db6fe39e942ec5f2233482e0b90bdb3b96 Mon Sep 17 00:00:00 2001 From: MARCHAND MANON Date: Tue, 22 Aug 2023 14:58:07 +0200 Subject: [PATCH] fix warning on export version --- js/lib/index.js | 1 - js/lib/jupyter-aladin.js | 10 ++++++---- js/lib/labplugin.js | 5 +++-- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/js/lib/index.js b/js/lib/index.js index f23cbfb1..56d06c65 100644 --- a/js/lib/index.js +++ b/js/lib/index.js @@ -1,4 +1,3 @@ // Export widget models and views, and the npm package version number. export {AladinModel, AladinView} from './jupyter-aladin'; -export {version} from '../package.json'; diff --git a/js/lib/jupyter-aladin.js b/js/lib/jupyter-aladin.js index 3df129bc..ab6dcd41 100644 --- a/js/lib/jupyter-aladin.js +++ b/js/lib/jupyter-aladin.js @@ -1,4 +1,6 @@ import { DOMWidgetModel, DOMWidgetView } from '@jupyter-widgets/base'; +import packageInfo from '../package.json'; + // Allow us to use the DOMWidgetView base class for our models/views. // Additionnaly, this is where we put by default all the external libraries // fetched by using webpack (see webpack.config.js file). @@ -61,11 +63,11 @@ export class AladinModel extends DOMWidgetModel { _model_name : 'AladinModel', _view_name : 'AladinView', - _model_module : 'ipyaladin', - _view_module : 'ipyaladin', + _model_module : packageInfo.name, + _view_module : packageInfo.name, - _model_module_version : '0.2.4', - _view_module_version : '0.2.4', + _model_module_version : packageInfo.version, + _view_module_version : packageInfo.version, }; } } diff --git a/js/lib/labplugin.js b/js/lib/labplugin.js index 84e235c4..f41510d1 100644 --- a/js/lib/labplugin.js +++ b/js/lib/labplugin.js @@ -1,5 +1,6 @@ -import {AladinModel, AladinView, version} from './index'; +import {AladinModel, AladinView} from './index'; import {IJupyterWidgetRegistry} from '@jupyter-widgets/base'; +import packageInfo from '../package.json'; export const aladinWidgetPlugin = { id: 'ipyaladin:plugin', @@ -7,7 +8,7 @@ export const aladinWidgetPlugin = { activate: function(app, widgets) { widgets.registerWidget({ name: 'ipyaladin', - version: version, + version: packageInfo.version, exports: { AladinModel, AladinView } }); },