Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a schematic for the angular package. #54

Open
doug0102 opened this issue Oct 14, 2022 · 4 comments
Open

Create a schematic for the angular package. #54

doug0102 opened this issue Oct 14, 2022 · 4 comments
Labels
enhancement New feature or request For Grooming help wanted Extra attention is needed

Comments

@doug0102
Copy link

doug0102 commented Oct 14, 2022

I think it would be useful to have an angular schematic so installation of the package would be a bit more streamlined. Currently you need to install the npm packages manually, update the app.module, then the global styles file. With a schematic this would all be taken care of for the user with just one command using the angular CLI.

Schematics for libraries

@vid
Copy link

vid commented Oct 14, 2022

I'm in the middle of extracting a library from vue's version of schematic. Although there are some benefits to opionated "training wheels," it makes some things, especially things off the beaten path, much more complex. Are there any particular issues this would make better than using standalone tools?

@doug0102
Copy link
Author

No not really, this was just a "nice to have" sort of thing. If it makes things needlessly difficult on your end then it might not be worth it.

@vid
Copy link

vid commented Oct 14, 2022

I don't think it would change anything for me, I'd mostly be concerned about porting in/out, and the extra overhead for onboarding people. It adds a lot of little fiddly scripts to maintain that are usually done differently, though I haven't seen its configure-on-install option before. OTOH I like to see any use of JSON-LD, and it looks like it's going in a components.js direction.

@ethanWallace
Copy link
Collaborator

Thanks @doug0102 for the suggestion, I will add it to my list of things to do!

@daine daine added the enhancement New feature or request label Jan 29, 2024
@adorayi adorayi added For Grooming help wanted Extra attention is needed labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request For Grooming help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants