bug: gcds-pagination navigation links (next, previous and the different pages) do not work in webkit / safari

[theonlyguills]

Prerequisites | Prérequis

• I have read the Contributing Guidelines. | J’ai lu les Lignes directrices sur les contributions.
• I agree to follow the Code of Conduct. | J’accepte de me conformer au Code de conduite.
• I have searched for existing issues that already report this problem, without success. | J’ai vérifié parmi les tickets (issues) existants que ce sujet n’avait pas déjà été soumis.

GC Design System Components Package and Version | Paquet et version des composants de Système de design GC

0.27.0

Current Behavior | Comportement observé

Clicking on any of the navigation links do not emit an onclick event or result in navigation

Expected Behavior | Comportement attendu

Navigation to the proper page

System Info | Information sur le système

Tested on iphone 14 and 16 with latest Safari and latest webkit on windows

Steps to Reproduce | Étapes pour reproduire le bogue

You can run the repro code below in the repro-webkit branch. No events get emitted on webkit. There is a patch on the branch already that fixes the problem. it can be applied by adding "postinstall": "patch-package"
to the "scripts" in package.json

It might require nuking node_modules to get rid of the vite cache.

Code Reproduction URL | URL de reproduction du code

https://github.com/theonlyguills/dfo-gcds-vue-testrig-ajcamr/tree/repro-webkit

Additional Information | Informations supplémentaires

WebKit does not seem to generate onclick events for things that don't have a tabindex if their href does not result in navigation. Adding a tabindex to all the links fixes the problem.

Also, without the tabindex, all the links are not keyboard accessible either on webkit.

[theonlyguills]

Also tested on 0.30.0 with the repro link above

[theonlyguills]

https://docs.webkit.org/Ports/WindowsPort.html#downloading-build-artifacts-from-buildbot
The build of webkit I used to test on windows

[daine]

@theonlyguills Thank you for reporting a bug! We're able to see the fix you have and will look into it further. At the moment we are pausing releases until the new year due to team capacity over the holidays.

Please react with a 👍 on the issue if this is something that affects you, it helps us with prioritization. If you have any use-cases, screenshots, etc to share, please don't hesitate to reach out to us or provide a comment below.

[theonlyguills]

Awesome, no rush, currently we implemented the patch-package script from the repro into our app so we're bundling the patched gcds. I imagine it would have impact on a lot of users given how widespread iOS devices are, but there is a workaround. Thanks!