From 1766ece40a31b99b497067d9e687ac2fd1f3fbc6 Mon Sep 17 00:00:00 2001 From: Ethan Wallace Date: Thu, 31 Aug 2023 07:47:07 -0400 Subject: [PATCH] Details update (#150) * Details a11y update * Update version to 1.6.1 --- build/figma/figma.tokens.json | 10 ++-------- build/web/css/.css | 7 +++---- build/web/css/components.css | 7 +++---- build/web/css/components/details.css | 7 +++---- build/web/css/tokens.css | 7 +++---- build/web/scss/.scss | 7 +++---- build/web/scss/components.scss | 7 +++---- build/web/scss/components/details.scss | 7 +++---- build/web/scss/tokens.scss | 7 +++---- package.json | 2 +- tokens/components/details/tokens.json | 10 ++-------- 11 files changed, 29 insertions(+), 49 deletions(-) diff --git a/build/figma/figma.tokens.json b/build/figma/figma.tokens.json index abcea4f5..1f9ec158 100644 --- a/build/figma/figma.tokens.json +++ b/build/figma/figma.tokens.json @@ -1473,7 +1473,7 @@ } }, "margin": { - "value": "0.375rem 0 0 0", + "value": "0.75rem 0 0 0", "type": "spacing" }, "padding": { @@ -1513,14 +1513,8 @@ } }, "padding": { - "value": "0.375rem", + "value": "0.375rem 0.375rem 0.375rem 2.25rem", "type": "spacing" - }, - "text": { - "margin": { - "value": "0 0 0 2.25rem", - "type": "spacing" - } } } }, diff --git a/build/web/css/.css b/build/web/css/.css index 468ded30..ae25b81d 100644 --- a/build/web/css/.css +++ b/build/web/css/.css @@ -1,6 +1,6 @@ /** * Do not edit directly - * Generated on Wed, 23 Aug 2023 14:12:27 GMT + * Generated on Wed, 30 Aug 2023 19:06:21 GMT */ :root { @@ -288,7 +288,7 @@ --gcds-details-hover-decoration-thickness: 0.125rem; --gcds-details-panel-border-color: #7d828b; --gcds-details-panel-border-width: 0.375rem; - --gcds-details-panel-margin: 0.375rem 0 0 0; + --gcds-details-panel-margin: 0.75rem 0 0 0; --gcds-details-panel-padding: 0.5625rem 2.25rem; --gcds-details-panel-slotted-margin: 1.5rem; --gcds-details-summary-arrow-border-left: 0.9375rem; @@ -296,8 +296,7 @@ --gcds-details-summary-arrow-left: 0.375rem; --gcds-details-summary-arrow-top: 0.5625rem; --gcds-details-summary-border-width: 0.0625rem; - --gcds-details-summary-padding: 0.375rem; - --gcds-details-summary-text-margin: 0 0 0 2.25rem; + --gcds-details-summary-padding: 0.375rem 0.375rem 0.375rem 2.25rem; --gcds-error-message-background: #fbddda; --gcds-error-message-border-color: #d3080c; --gcds-error-message-border-width: 0.125rem; diff --git a/build/web/css/components.css b/build/web/css/components.css index ca7d8941..6e294f52 100644 --- a/build/web/css/components.css +++ b/build/web/css/components.css @@ -1,6 +1,6 @@ /** * Do not edit directly - * Generated on Wed, 23 Aug 2023 14:12:27 GMT + * Generated on Wed, 30 Aug 2023 19:06:21 GMT */ :root { @@ -177,7 +177,7 @@ --gcds-details-hover-decoration-thickness: 0.125rem; --gcds-details-panel-border-color: #7d828b; --gcds-details-panel-border-width: 0.375rem; - --gcds-details-panel-margin: 0.375rem 0 0 0; + --gcds-details-panel-margin: 0.75rem 0 0 0; --gcds-details-panel-padding: 0.5625rem 2.25rem; --gcds-details-panel-slotted-margin: 1.5rem; --gcds-details-summary-arrow-border-left: 0.9375rem; @@ -185,8 +185,7 @@ --gcds-details-summary-arrow-left: 0.375rem; --gcds-details-summary-arrow-top: 0.5625rem; --gcds-details-summary-border-width: 0.0625rem; - --gcds-details-summary-padding: 0.375rem; - --gcds-details-summary-text-margin: 0 0 0 2.25rem; + --gcds-details-summary-padding: 0.375rem 0.375rem 0.375rem 2.25rem; --gcds-error-message-background: #fbddda; --gcds-error-message-border-color: #d3080c; --gcds-error-message-border-width: 0.125rem; diff --git a/build/web/css/components/details.css b/build/web/css/components/details.css index 0dfdebaf..788b17dd 100644 --- a/build/web/css/components/details.css +++ b/build/web/css/components/details.css @@ -1,6 +1,6 @@ /** * Do not edit directly - * Generated on Mon, 19 Jun 2023 20:28:18 GMT + * Generated on Wed, 30 Aug 2023 19:06:21 GMT */ :root { @@ -18,7 +18,7 @@ --gcds-details-hover-decoration-thickness: 0.125rem; --gcds-details-panel-border-color: #7d828b; --gcds-details-panel-border-width: 0.375rem; - --gcds-details-panel-margin: 0.375rem 0 0 0; + --gcds-details-panel-margin: 0.75rem 0 0 0; --gcds-details-panel-padding: 0.5625rem 2.25rem; --gcds-details-panel-slotted-margin: 1.5rem; --gcds-details-summary-arrow-border-left: 0.9375rem; @@ -26,6 +26,5 @@ --gcds-details-summary-arrow-left: 0.375rem; --gcds-details-summary-arrow-top: 0.5625rem; --gcds-details-summary-border-width: 0.0625rem; - --gcds-details-summary-padding: 0.375rem; - --gcds-details-summary-text-margin: 0 0 0 2.25rem; + --gcds-details-summary-padding: 0.375rem 0.375rem 0.375rem 2.25rem; } diff --git a/build/web/css/tokens.css b/build/web/css/tokens.css index 468ded30..ae25b81d 100644 --- a/build/web/css/tokens.css +++ b/build/web/css/tokens.css @@ -1,6 +1,6 @@ /** * Do not edit directly - * Generated on Wed, 23 Aug 2023 14:12:27 GMT + * Generated on Wed, 30 Aug 2023 19:06:21 GMT */ :root { @@ -288,7 +288,7 @@ --gcds-details-hover-decoration-thickness: 0.125rem; --gcds-details-panel-border-color: #7d828b; --gcds-details-panel-border-width: 0.375rem; - --gcds-details-panel-margin: 0.375rem 0 0 0; + --gcds-details-panel-margin: 0.75rem 0 0 0; --gcds-details-panel-padding: 0.5625rem 2.25rem; --gcds-details-panel-slotted-margin: 1.5rem; --gcds-details-summary-arrow-border-left: 0.9375rem; @@ -296,8 +296,7 @@ --gcds-details-summary-arrow-left: 0.375rem; --gcds-details-summary-arrow-top: 0.5625rem; --gcds-details-summary-border-width: 0.0625rem; - --gcds-details-summary-padding: 0.375rem; - --gcds-details-summary-text-margin: 0 0 0 2.25rem; + --gcds-details-summary-padding: 0.375rem 0.375rem 0.375rem 2.25rem; --gcds-error-message-background: #fbddda; --gcds-error-message-border-color: #d3080c; --gcds-error-message-border-width: 0.125rem; diff --git a/build/web/scss/.scss b/build/web/scss/.scss index b6b8952d..ea5091be 100644 --- a/build/web/scss/.scss +++ b/build/web/scss/.scss @@ -1,6 +1,6 @@ // Do not edit directly -// Generated on Wed, 23 Aug 2023 14:12:27 GMT +// Generated on Wed, 30 Aug 2023 19:06:21 GMT $gcds-color-blue-100: #d7e5f5; $gcds-color-blue-500: #6584a6; // Must contrast 3:1 with white @@ -286,7 +286,7 @@ $gcds-details-hover-text: #0535d2; $gcds-details-hover-decoration-thickness: 0.125rem; $gcds-details-panel-border-color: #7d828b; $gcds-details-panel-border-width: 0.375rem; -$gcds-details-panel-margin: 0.375rem 0 0 0; +$gcds-details-panel-margin: 0.75rem 0 0 0; $gcds-details-panel-padding: 0.5625rem 2.25rem; $gcds-details-panel-slotted-margin: 1.5rem; $gcds-details-summary-arrow-border-left: 0.9375rem; @@ -294,8 +294,7 @@ $gcds-details-summary-arrow-border-top-bottom: 0.5625rem; $gcds-details-summary-arrow-left: 0.375rem; $gcds-details-summary-arrow-top: 0.5625rem; $gcds-details-summary-border-width: 0.0625rem; -$gcds-details-summary-padding: 0.375rem; -$gcds-details-summary-text-margin: 0 0 0 2.25rem; +$gcds-details-summary-padding: 0.375rem 0.375rem 0.375rem 2.25rem; $gcds-error-message-background: #fbddda; $gcds-error-message-border-color: #d3080c; $gcds-error-message-border-width: 0.125rem; diff --git a/build/web/scss/components.scss b/build/web/scss/components.scss index 1e205e58..adaea42a 100644 --- a/build/web/scss/components.scss +++ b/build/web/scss/components.scss @@ -1,6 +1,6 @@ // Do not edit directly -// Generated on Wed, 23 Aug 2023 14:12:27 GMT +// Generated on Wed, 30 Aug 2023 19:06:21 GMT $gcds-container-border: 0.0625rem solid #7d828b; $gcds-container-size-xs: 20rem; @@ -175,7 +175,7 @@ $gcds-details-hover-text: #0535d2; $gcds-details-hover-decoration-thickness: 0.125rem; $gcds-details-panel-border-color: #7d828b; $gcds-details-panel-border-width: 0.375rem; -$gcds-details-panel-margin: 0.375rem 0 0 0; +$gcds-details-panel-margin: 0.75rem 0 0 0; $gcds-details-panel-padding: 0.5625rem 2.25rem; $gcds-details-panel-slotted-margin: 1.5rem; $gcds-details-summary-arrow-border-left: 0.9375rem; @@ -183,8 +183,7 @@ $gcds-details-summary-arrow-border-top-bottom: 0.5625rem; $gcds-details-summary-arrow-left: 0.375rem; $gcds-details-summary-arrow-top: 0.5625rem; $gcds-details-summary-border-width: 0.0625rem; -$gcds-details-summary-padding: 0.375rem; -$gcds-details-summary-text-margin: 0 0 0 2.25rem; +$gcds-details-summary-padding: 0.375rem 0.375rem 0.375rem 2.25rem; $gcds-error-message-background: #fbddda; $gcds-error-message-border-color: #d3080c; $gcds-error-message-border-width: 0.125rem; diff --git a/build/web/scss/components/details.scss b/build/web/scss/components/details.scss index eff0c20a..997d91e9 100644 --- a/build/web/scss/components/details.scss +++ b/build/web/scss/components/details.scss @@ -1,6 +1,6 @@ // Do not edit directly -// Generated on Mon, 19 Jun 2023 20:28:18 GMT +// Generated on Wed, 30 Aug 2023 19:06:21 GMT $gcds-details-default-text: #2b4380; $gcds-details-default-decoration-thickness: 0.0625rem; @@ -16,7 +16,7 @@ $gcds-details-hover-text: #0535d2; $gcds-details-hover-decoration-thickness: 0.125rem; $gcds-details-panel-border-color: #7d828b; $gcds-details-panel-border-width: 0.375rem; -$gcds-details-panel-margin: 0.375rem 0 0 0; +$gcds-details-panel-margin: 0.75rem 0 0 0; $gcds-details-panel-padding: 0.5625rem 2.25rem; $gcds-details-panel-slotted-margin: 1.5rem; $gcds-details-summary-arrow-border-left: 0.9375rem; @@ -24,5 +24,4 @@ $gcds-details-summary-arrow-border-top-bottom: 0.5625rem; $gcds-details-summary-arrow-left: 0.375rem; $gcds-details-summary-arrow-top: 0.5625rem; $gcds-details-summary-border-width: 0.0625rem; -$gcds-details-summary-padding: 0.375rem; -$gcds-details-summary-text-margin: 0 0 0 2.25rem; +$gcds-details-summary-padding: 0.375rem 0.375rem 0.375rem 2.25rem; \ No newline at end of file diff --git a/build/web/scss/tokens.scss b/build/web/scss/tokens.scss index b6b8952d..ea5091be 100644 --- a/build/web/scss/tokens.scss +++ b/build/web/scss/tokens.scss @@ -1,6 +1,6 @@ // Do not edit directly -// Generated on Wed, 23 Aug 2023 14:12:27 GMT +// Generated on Wed, 30 Aug 2023 19:06:21 GMT $gcds-color-blue-100: #d7e5f5; $gcds-color-blue-500: #6584a6; // Must contrast 3:1 with white @@ -286,7 +286,7 @@ $gcds-details-hover-text: #0535d2; $gcds-details-hover-decoration-thickness: 0.125rem; $gcds-details-panel-border-color: #7d828b; $gcds-details-panel-border-width: 0.375rem; -$gcds-details-panel-margin: 0.375rem 0 0 0; +$gcds-details-panel-margin: 0.75rem 0 0 0; $gcds-details-panel-padding: 0.5625rem 2.25rem; $gcds-details-panel-slotted-margin: 1.5rem; $gcds-details-summary-arrow-border-left: 0.9375rem; @@ -294,8 +294,7 @@ $gcds-details-summary-arrow-border-top-bottom: 0.5625rem; $gcds-details-summary-arrow-left: 0.375rem; $gcds-details-summary-arrow-top: 0.5625rem; $gcds-details-summary-border-width: 0.0625rem; -$gcds-details-summary-padding: 0.375rem; -$gcds-details-summary-text-margin: 0 0 0 2.25rem; +$gcds-details-summary-padding: 0.375rem 0.375rem 0.375rem 2.25rem; $gcds-error-message-background: #fbddda; $gcds-error-message-border-color: #d3080c; $gcds-error-message-border-width: 0.125rem; diff --git a/package.json b/package.json index 28b4c6f7..2845af48 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@cdssnc/gcds-tokens", - "version": "1.6.0", + "version": "1.6.1", "author": "Government of Canada | Gouvernement du Canada", "description": "GC Design System Tokens", "homepage": "https://design-system.alpha.canada.ca/", diff --git a/tokens/components/details/tokens.json b/tokens/components/details/tokens.json index 94fc66b4..134fdfe9 100644 --- a/tokens/components/details/tokens.json +++ b/tokens/components/details/tokens.json @@ -80,7 +80,7 @@ } }, "margin": { - "value": "{spacing.100.value} 0 0 0", + "value": "{spacing.200.value} 0 0 0", "type": "spacing" }, "padding": { @@ -120,14 +120,8 @@ } }, "padding": { - "value": "{spacing.100.value}", + "value": "{spacing.100.value} {spacing.100.value} {spacing.100.value} {spacing.450.value}", "type": "spacing" - }, - "text": { - "margin": { - "value": "0 0 0 {spacing.450.value}", - "type": "spacing" - } } } }