From 00d4023f671c241ee9784a440991c1e072cb76c6 Mon Sep 17 00:00:00 2001
From: Stephen McMurtry <smcmurtry@gmail.com>
Date: Mon, 12 Jul 2021 08:49:00 -0600
Subject: [PATCH] Added alt text to the Canada Wordmark (#91)

* added alt text to the canada wordmark

* added some pytest config and fixed the broken tests
---
 .../jinja_templates/email_preview_template.jinja2             | 2 +-
 notifications_utils/jinja_templates/email_template.jinja2     | 2 +-
 setup.cfg                                                     | 2 ++
 tests/test_template_types.py                                  | 4 ++--
 4 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/notifications_utils/jinja_templates/email_preview_template.jinja2 b/notifications_utils/jinja_templates/email_preview_template.jinja2
index 016e0cd4..44b051de 100644
--- a/notifications_utils/jinja_templates/email_preview_template.jinja2
+++ b/notifications_utils/jinja_templates/email_preview_template.jinja2
@@ -83,7 +83,7 @@
         <div style="margin: 10px 0 20px 0; float: right">
           <img
             src="https://{{ asset_domain }}/canada-logo.png"
-            alt=" "
+            alt="Symbol of the Government of Canada / Symbole du gouvernement du Canada"
             height="55"
             width="123"
           />
diff --git a/notifications_utils/jinja_templates/email_template.jinja2 b/notifications_utils/jinja_templates/email_template.jinja2
index be81bda5..be226dc3 100644
--- a/notifications_utils/jinja_templates/email_template.jinja2
+++ b/notifications_utils/jinja_templates/email_template.jinja2
@@ -174,7 +174,7 @@
           <td style="line-height: 0px; border: 0; padding: 0">
             <img
               src="https://assets.notification.canada.ca/canada-logo.png?20210531"
-              alt=" "
+              alt="Symbol of the Government of Canada / Symbole du gouvernement du Canada"
               width="123"
               height="55"
               border="0"
diff --git a/setup.cfg b/setup.cfg
index f553d807..57186c3d 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -1,5 +1,7 @@
 [tool:pytest]
 xfail_strict=true
+testpaths = tests
+addopts = -p no:warnings -n4
 
 [flake8]
 # W504 line break after binary operator
diff --git a/tests/test_template_types.py b/tests/test_template_types.py
index 0ed66c5c..e7d811c4 100644
--- a/tests/test_template_types.py
+++ b/tests/test_template_types.py
@@ -160,7 +160,7 @@ def test_alt_text_with_no_brand_text_and_fip_banner_english_shown(renderer):
             brand_name="Notify Logo",
         )
     )
-    assert 'alt=" "' in email
+    assert 'alt="Symbol of the Government of Canada / Symbole du gouvernement du Canada"' in email
     assert 'alt="Notify Logo"' in email
 
 
@@ -177,7 +177,7 @@ def test_alt_text_with_no_brand_text_and_fip_banner_french_shown(renderer):
             brand_name="Notify Logo",
         )
     )
-    assert 'alt=" "' in email
+    assert 'alt="Symbol of the Government of Canada / Symbole du gouvernement du Canada"' in email
     assert 'alt="Notify Logo"' in email