Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing check for map parameters attributes in grid mapping variable? #94

Open
kyleredilla opened this issue Jul 9, 2021 · 2 comments
Assignees

Comments

@kyleredilla
Copy link

Hello! Thanks to all the contributors for the work on this handy tool. This might not be an issue, but - should the checker return errors if a grid mapping variable is missing the attributes corresponding to "Map Parameters" in the Grid Mappings Appendix of the conventions?

Take for example the first grid mapping, Albers Conical Equal Area. Some parameters say "optional" (false_easting and false_northing), which seems to imply that the others would not be optional, right?

Currently, I can omit at least some of those "non-optional" parameters for multiple grid mappings (have tried the above and Polar Stereographic) and the checker doesn't flag it - I can give an example if needed. This seems intentional however, so I'm just wondering if there was a reason the checker doesn't do this, or if it is something that should be considered. Thanks!

@RosalynHatcher
Copy link
Contributor

Hi,

Thanks for raising this. I think this is something the checker could and should check for. It looks like this is missing from the conformance document. I will suggest this is added to the conformance document and then I can fix the checker.

Regards,
Ros.

@RosalynHatcher RosalynHatcher self-assigned this Oct 22, 2021
@kyleredilla
Copy link
Author

Great, thanks! Gosh, I this is the first I've heard about the conformance document, that is a helpful resource!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants