Release Notification - 128.4.x

[amaitland]

Release 128.4.x

• Create cefsharp/128 release branch
• Update DevTools client API
• Update to latest CEF build
• Resolve remaining issues attached to 128 Milestone
• Create release notes
• Release stable packages to nuget.org
• Update Issue Template CEF Sample application links
• Generate new API Doc and upload to http://cefsharp.github.io/api/
• Update General Usage API doc links

[amaitland]

The Alloy Bootstrap has been removed (#4795)

There are multiple breaking changes. 19739ab

[kpreisser]

Hi @amaitland, thanks for your work on releasing the new version!

I noticed that when using CefSharp.Wpf.HwndHost 127.3.50 together with the new version CefSharp.Common.NETCore 128.4.90, the Chrome style is always used for the ChromiumWebBrowser, e.g. the context menu shows entries for opening the developer tools, and new windows will have the full chrome appearance. This happens even when setting CefSharpSettings.RuntimeStyle = CefRuntimeStyle.Alloy.

I noticed this seems to be because ChromiumWebBrowser.CreateBrowserWindowInfo() in CefSharp.Wpf.HwndHost doesn't set the IWindowInfo.RuntimeStyle property:

        protected virtual IWindowInfo CreateBrowserWindowInfo(IntPtr handle)
        {
            var windowInfo = new WindowInfo();
            windowInfo.SetAsChild(handle);

            if (!ActivateBrowserOnCreation)
            {
                //Disable Window activation by default
                //https://bitbucket.org/chromiumembedded/cef/issues/1856/branch-2526-cef-activates-browser-window
                windowInfo.ExStyle |= WS_EX_NOACTIVATE;
            }

            return windowInfo;
        }

whereas e.g. the WinForms ChromiumWebBrowser sets it:

CefSharp/CefSharp.WinForms/ChromiumWebBrowser.cs

Lines 654 to 668 in 53d551f

	protected virtual IWindowInfo CreateBrowserWindowInfo(IntPtr handle)
	{
	var windowInfo = Core.ObjectFactory.CreateWindowInfo();
	windowInfo.RuntimeStyle = CefSharpSettings.RuntimeStyle ?? CefRuntimeStyle.Alloy;
	windowInfo.SetAsChild(handle);
	if (!ActivateBrowserOnCreation)
	{
	//Disable Window activation by default
	//https://github.com/chromiumembedded/cef/issues/1856/branch-2526-cef-activates-browser-window
	windowInfo.ExStyle |= WS_EX_NOACTIVATE;
	}
	return windowInfo;
	}

Is this something that needs to be done for a new CefSharp.Wpf.HwndHost release?
(In the meanwhile, I created a subclass of ChromiumWebBrowser in our application that overrides CreateBrowserWindowInfo and sets the runtime style, and now the alloy style is correctly used.)

Thanks!

[amaitland]

Is this something that needs to be done for a new CefSharp.Wpf.HwndHost release?

Yep, that was the plan. Change made in commit cefsharp/CefSharp.Wpf.HwndHost@0be6802

New build of HwndHost is now out. Thanks for the reminder.

Anything that's inconsistent or a change you'd like to propose then feel free to submit a PR 👍

Happy to take feedback from the community 😄

[kpreisser]

Thanks!