Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating mobile toolbar #54

Closed
AstroChara opened this issue Sep 12, 2023 · 13 comments
Closed

Updating mobile toolbar #54

AstroChara opened this issue Sep 12, 2023 · 13 comments

Comments

@AstroChara
Copy link

Currently the mobile toolbar is rather clunky and difficult to use, contributing to numerous complaints about people not being able to move around. I believe it is a good idea to update this.

Ideas which have been suggested on Discord are:

  • (Chara) Remove the + and - buttons (we already have pinch zooming which serves the same purpose), opening up two slots.
  • (Chara) Put the 'Go' button in the tool bar (instead of inside Information).
  • (pedroJ) Put the Search button in the tool bar.
  • (TheLostProbe) Rename 'Star Browser' to 'Object Browser' or 'Celestial Browser' (also see Suggestion: Improve Star Browsing's star selection UI #35).
  • (Chara) For vertical screens, move the toolbar to the bottom so it blocks less space. Move the text at the bottom to just above the toolbar.
@levinli303
Copy link
Collaborator

For + and - buttons, I actually want to know how well the current pinch gesture works. I definitely want to get rid of these buttons (moving them into camera control).

"search" is a good candidate to put in the toolbar, but i'm not sure about "go", since tapping multiple times could lead to bad behaviors.

for the last item, i think it would be best to have some example apps that we can learn from, their existing UI.

@levinli303
Copy link
Collaborator

levinli303 commented Sep 15, 2023

Removing +/- and adding search is done in #55 and celestiamobile/AndroidCelestia#68

@AstroChara
Copy link
Author

"search" is a good candidate to put in the toolbar, but i'm not sure about "go", since tapping multiple times could lead to bad behaviors.

Bad behaviors?

for the last item, i think it would be best to have some example apps that we can learn from, their existing UI.

I don't know about any specific examples, but I'm pretty sure a lot of mobile apps used vertically generally place their toolbar at the bottom.

@levinli303
Copy link
Collaborator

levinli303 commented Sep 18, 2023

Bad behaviors?

tapping on Go (g key command) multiple times would result in a getting too close to the object.

@AstroChara
Copy link
Author

Bad behaviors?

tapping on Go (g key command) multiple times would result in a getting too close to the object.

I don't really see why this is a reason to not include Go into the toolbar. It's the user's problem if they mash the button and end up getting too close to the object than they'd like.

@levinli303
Copy link
Collaborator

I don't really see why this is a reason to not include Go into the toolbar. It's the user's problem if they mash the button and end up getting too close to the object than they'd like.

the only way to add a go button in toolbar is that the action should be persistent to give a better experience. i do not want to just bring the g command here. i'd like it to be implemented in a different way.

What i have in mind is that:

  1. if the object is within NUM x radius distance, do nothing.
  2. If the object is not within NUM x radius, use goToLonLat with distance = NUM * radius, longitude = xxx, latitude = xxx

@AstroChara
Copy link
Author

Still don't see what the problem is, but sure I guess.

@levinli303
Copy link
Collaborator

For the last item, i am exploring with BottomAppBar on Android, it looks like this in potrait mode, landscape mode will keep the old appearance:

Screenshot_20231024-103702

@levinli303
Copy link
Collaborator

i am tempted to allow customization for the items in toolbar including what items users want to put and in what order.

@AstroChara
Copy link
Author

i am tempted to allow customization for the items in toolbar including what items users want to put and in what order.

That's a good idea. I'd like to see us being able to tailor our toolbar to fit our own preferences.

@levinli303
Copy link
Collaborator

levinli303 commented Nov 14, 2023

I have not started working on it yet but i think customization should be part of Celestia PLUS on release (should be in 1.6.2).

Default buttons will be "Mode", "Info", "Search", "Menu", "Close". I plan to add "Go", "Zoom In", "Zoom Out" to the list of supported.

I will decide if customization will be added as standard feature in the future.

@levinli303
Copy link
Collaborator

iOS design

IMG_7773

@levinli303
Copy link
Collaborator

Done in 1.6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants