Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for message inclusion before committing to a block #205

Closed
evan-forbes opened this issue Feb 9, 2022 · 0 comments · Fixed by #216
Closed

Check for message inclusion before committing to a block #205

evan-forbes opened this issue Feb 9, 2022 · 0 comments · Fixed by #216
Assignees

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Feb 9, 2022

Since we will be using ABCI++ soon, it should be much easier to implement a message inclusion check that can be performed when a validator processes a proposal block. This issue has been described in more depth previously in celestiaorg/celestia-core#520 and #1006. We also have a pending ADR celestiaorg/celestia-core#559

This check should ensure that

  • each valid PayForMessage has a corresponding message with the correct commitment
  • that there are no unaccounted for messages included in the square

blocked by #381 (might be able to be done in the same PR since they are so related)

blocked by celestiaorg/celestia-core#204

@evan-forbes evan-forbes transferred this issue from celestiaorg/celestia-core Feb 9, 2022
@evan-forbes evan-forbes moved this to TODO in Celestia Node Feb 14, 2022
@evan-forbes evan-forbes self-assigned this Feb 14, 2022
Repository owner moved this from TODO to Done in Celestia Node May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant