Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single node script doesn't run on v0.11.x #2101

Closed
rootulp opened this issue Jul 13, 2023 · 2 comments
Closed

Single node script doesn't run on v0.11.x #2101

rootulp opened this issue Jul 13, 2023 · 2 comments
Assignees
@rach-id
Labels
bug Something isn't working

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jul 13, 2023 •
edited
Loading

Context

I'm trying to debug #2098 by running a local devnet node on the v0.11.x release branch. So far I've tried 0.11.0 and 0.11.2.

Problem

$ ./scripts/single-node.sh

Error: unknown flag: --ethereum-address

If I remove

celestia-app/scripts/single-node.sh

Line 17 in 4a0ac5d

--ethereum-address 0x966e6f22781EF6a6A82BBB4DB3df8E225DfD9488 # private key: da6ed55cb2894ac2c9c10209c09de8e8b9d109b910338d5bf3d747a7e1fc9eb9
from the script, then I get

Error: failed to build create-validator message: the provided eth address is not a valid hex address

cc: @sweexordious
@rootulp rootulp added the bug Something isn't working label Jul 13, 2023
@rach-id
Copy link
Member

rach-id commented Jul 13, 2023

That branch is missing this commit: eb5fe09

@rach-id rach-id mentioned this issue Jul 13, 2023
Merged
5 tasks
rach-id added a commit that referenced this issue Jul 18, 2023
@rach-id @evan-forbes
fix: single node script (#929) (#2102)
9d8b113 
fixes a left pver `--ethereum-address`

(cherry picked from commit eb5fe09)

<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

Cherry pick eb5fe09

Fixes: #2101

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords

Co-authored-by: Evan Forbes <[email protected]>
@rootulp
Copy link
Collaborator Author

rootulp commented Jul 19, 2023

Closed by #2102

@rootulp rootulp closed this as completed Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rach-id rach-id

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rootulp @rach-id