Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version gas schedule variables #3404

Closed
2 tasks done
cmwaters opened this issue Apr 29, 2024 · 6 comments · Fixed by #3735
Closed
2 tasks done

Version gas schedule variables #3404

cmwaters opened this issue Apr 29, 2024 · 6 comments · Fixed by #3735
Assignees
@cmwaters @ninabarbakadze
Labels
WS: BestTxs Reliable and seamless transaction flow
Milestone
v3

Comments

@cmwaters
Copy link
Contributor

cmwaters commented Apr 29, 2024 •
edited by rootulp
Loading

All on-chain governance modifiable parameters associated with the gas scheduler (i.e. GasCostPayForBlobs) should become versioned parameters i.e. they can only change with a hard fork upgrade.

The reason is to help clients who are submitting transactions make it easier to estimate the gas (as it won't fluctuate from block to block and you won't need additional queries for these values - they can be hardcoded into your estimator)

Context: #3011 (comment)_

Acceptance Criteria

  • Write a CIP
  • Implement the change
@cmwaters cmwaters added WS: BestTxs Reliable and seamless transaction flow WS: V2 ✌️ lemongrass hardfork related labels Apr 29, 2024
@rootulp
Copy link
Collaborator

rootulp commented Apr 29, 2024

All on-chain governance modifiable parameters should become versioned parameters

Clarifying question: do you mean all params or just the params related to the gas scheduler?

I'm a fan of moving governance modifiable params to versioned constants. IMO this likely warrants a CIP b/c it's moving scope for modifying these params from token governance to the CIP process. I think this will be a relatively small code change but it will take time to get through the CIP process so I think it's unlikely to get finalized prior to our scheduled feature freeze on May 15th for v2.

@cmwaters
Copy link
Contributor Author

Just related to the gas scheduler. I thought I had specified it but I must have missed it. Thanks for catching it.

@rootulp rootulp removed the WS: V2 ✌️ lemongrass hardfork related label May 1, 2024
@rootulp rootulp added this to the v3 milestone May 1, 2024
@rootulp
Copy link
Collaborator

rootulp commented May 1, 2024

The two params that are being considered:

  • auth.TxSizeCostPerByte
  • blob.GasPerBlobByte

@evan-forbes evan-forbes added ice-box this label is automatically applied to all issues. it is removed after starting work and removed needs:priority labels May 6, 2024
@cmwaters
Copy link
Contributor Author

cmwaters commented Jun 5, 2024

Can we have this planned for v3? @evan-forbes

@cmwaters
Copy link
Contributor Author

cmwaters commented Jun 7, 2024

We would first need to write a CIP on this

@cmwaters cmwaters removed the ice-box this label is automatically applied to all issues. it is removed after starting work label Jun 11, 2024
@evan-forbes evan-forbes added the needs:discussion item needs to be discussed as a group in the next sync. if marking an item, pls be prepped to talk label Jul 1, 2024
@evan-forbes evan-forbes removed the needs:discussion item needs to be discussed as a group in the next sync. if marking an item, pls be prepped to talk label Jul 8, 2024
@ninabarbakadze ninabarbakadze mentioned this issue Jul 25, 2024
Merged
@ninabarbakadze ninabarbakadze mentioned this issue Aug 1, 2024
Closed
2 tasks
@rootulp rootulp changed the title Version gas scheduler variables Version gas schedule variables Sep 11, 2024
ninabarbakadze added a commit that referenced this issue Sep 20, 2024
@ninabarbakadze @rootulp
refactor!: version gas scheduler variables (#3735)
857d107 
## Overview

- Fixes #3404 
- Fixes #3748 
- Fixes #3762

---------

Co-authored-by: Rootul P <[email protected]>
@rootulp
Copy link
Collaborator

rootulp commented Sep 20, 2024

For posterity:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmwaters cmwaters

@ninabarbakadze ninabarbakadze

Labels
WS: BestTxs Reliable and seamless transaction flow
Projects
None yet
Milestone
v3
Development

Successfully merging a pull request may close this issue.

refactor!: version gas scheduler variables celestiaorg/celestia-app
4 participants
@rootulp @cmwaters @evan-forbes @ninabarbakadze