Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the evidence module in v4 #3889

Open
ninabarbakadze opened this issue Sep 19, 2024 · 3 comments · May be fixed by #3945
Open

Remove the evidence module in v4 #3889

ninabarbakadze opened this issue Sep 19, 2024 · 3 comments · May be fixed by #3945
Assignees
@ninabarbakadze
Labels
nice to have item is not blocking or required. WS: V4

Comments

@ninabarbakadze
Copy link
Member

Description

After writing AppHash test we realised that we have a msg MsgSubmitEvidence that's not used and should probably be disabled in v3
@ninabarbakadze ninabarbakadze added the WS: V3 3️⃣ item is directly relevant to the v3 hardfork label Sep 19, 2024
@rootulp
Copy link
Collaborator

rootulp commented Sep 20, 2024

Can you elaborate on how/why it's not used? It looks like it's part of the x/evidence module still: https://github.com/celestiaorg/cosmos-sdk/blob/release/v0.46.x-celestia/x/evidence/spec/03_messages.md#msgsubmitevidence

@evan-forbes evan-forbes added the nice to have item is not blocking or required. label Sep 22, 2024
@rootulp
Copy link
Collaborator

rootulp commented Sep 30, 2024

Additional context from in-person sync:

  • Most Cosmos chains have this module but don't use it because evidence is handled by CometBFT.
  • We've had x/evidence since app version 1 and it hasn't been an issue so far.
  • Given this is a "nice to have" it likely won't be included in v3

@ninabarbakadze ninabarbakadze self-assigned this Oct 7, 2024
@rootulp rootulp linked a pull request Oct 7, 2024 that will close this issue
Draft
@rootulp rootulp added WS: V4 and removed WS: V3 3️⃣ item is directly relevant to the v3 hardfork labels Oct 8, 2024
@ninabarbakadze ninabarbakadze changed the title Remove the evidence module in v3 Remove the evidence module in v4 Oct 15, 2024
@tac0turtle
Copy link
Contributor

by removing evidence you allow validators to double sign with no repercussion: https://github.com/cosmos/cosmos-sdk/blob/fc91e76354512e8538f9da5bc9d3518f54921417/x/evidence/keeper/abci.go#L28. Is this desired?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ninabarbakadze ninabarbakadze

Labels
nice to have item is not blocking or required. WS: V4
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: disable evidence module celestiaorg/celestia-app
4 participants
@rootulp @tac0turtle @evan-forbes @ninabarbakadze