Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor e2e tests to improve structure and reduce argument count #3907

Open
mojtaba-esk opened this issue Sep 25, 2024 · 0 comments
Open

Refactor e2e tests to improve structure and reduce argument count #3907

mojtaba-esk opened this issue Sep 25, 2024 · 0 comments
Labels
external testing items that are strictly related to adding or extending test coverage

Comments

@mojtaba-esk
Copy link
Member

The current e2e test setup could be improved by refactoring to enhance code readability and maintainability. Specifically, several functions have an excessive number of arguments, which can be streamlined using options or by passing relevant structs. Additionally, passing the *knuu.Knuu struct to the testnet constructor would be a cleaner approach. This issue aims to address these points by refactoring the test suite to make it more idiomatic and manageable.

Originally posted by @cmwaters in #3900 (review)

@mojtaba-esk mojtaba-esk added the testing items that are strictly related to adding or extending test coverage label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external testing items that are strictly related to adding or extending test coverage
Projects
None yet
Development

No branches or pull requests

1 participant