Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebuilt binaries don't get attached for -arabica or -mocha tag #3926

Open
rootulp opened this issue Sep 30, 2024 · 0 comments · May be fixed by #3929
Open

Prebuilt binaries don't get attached for -arabica or -mocha tag #3926

rootulp opened this issue Sep 30, 2024 · 0 comments · May be fixed by #3929
Labels
bug Something isn't working CI item that directly relates to or modify the CI good first issue Good for newcomers

Comments

@rootulp
Copy link
Collaborator

rootulp commented Sep 30, 2024

Context

We recently shifted to creating -arabica, -mocha tags for each release.

- name: Create prebuilt binaries and attach them to the GitHub release
run: make prebuilt-binary

git:
prerelease_suffix: "-rc"

Problem

GoReleaser didn't attach prebuilt binaries to:

GoReleaser thinks the latest tag is v2.2.0-rc0 instead of v2.2.0-arabica or v2.2.0-mocha. See https://github.com/celestiaorg/celestia-app/actions/runs/11020450957/job/30605337119#step:6:99

Proposal

Fix GoReleaser config so that it can attach prebuilt binaries to these releases. A few tips:

  1. Ask questions in GoReleaser Discord or submit a GH issue with details
  2. Investigate the prerelease_suffix
@rootulp rootulp added bug Something isn't working good first issue Good for newcomers CI item that directly relates to or modify the CI labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI item that directly relates to or modify the CI good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant