Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to only serve grpc instead of wrapping the json rpc with a grpc server #1478

Open
evan-forbes opened this issue Sep 12, 2024 · 1 comment
Assignees

Comments

@evan-forbes
Copy link
Member

Instead of wrapping the json rpc, we could simply use a grpc server for the endpoints that node uses.

GetSignedBlockByHeight
GetSignedBlockByHash
subscribe to new SignedBlockEvent

subscription could optionally be implemented on the client side

@rach-id
Copy link
Member

rach-id commented Sep 23, 2024

The final list of endpoints:

  • BlockByHash:
    • Request: block hash
    • Response: block
    • Details:
      • Response to be streamed
  • BlockByHeight:
    • Request: block height
    • Response: block
    • Details:
      • Response to be streamed
  • Commit:
    • Request: block hash
    • Response: commit
  • BlockChunkByHash:
    • Request:
      • hash or height?
      • chunk index
    • Response:
      • chunk
  • ValidatorSet:
    • Request: height
    • Response: validator set
  • Events subscription:
    • notification of new {height, hash}

ideally, signedblockbyheight endpoint, but that’s a nice to have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants