Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blob: Unify GetProof and GetCommitmentProof #3516

Open
rach-id opened this issue Jun 20, 2024 · 3 comments · May be fixed by #3821
Open

blob: Unify GetProof and GetCommitmentProof #3516

rach-id opened this issue Jun 20, 2024 · 3 comments · May be fixed by #3821
Labels
external Issues created by non node team members v0.17.0 Intended for v0.17.0 release

Comments

@rach-id
Copy link
Member

rach-id commented Jun 20, 2024 

          One potential idea is to fix GetProof instead of introducing a new endpoint with equivalent purpose. We could copy @rach-id's implementation of proof compute and solve the EDS fetching inefficiency later on with Shwap.

Originally posted by @Wondertan in #3470 (comment)
@rach-id rach-id mentioned this issue Jun 20, 2024
Merged
@github-actions github-actions bot added the external Issues created by non node team members label Jun 20, 2024
@renaynay
Copy link
Member

Closing this issue as Proof now proves the blob up to the data root via #3470

@Wondertan
Copy link
Member

@renaynay. this wasn't fixed and this is a follow up issue from #3470. We still have two methods GetProof and GetCommitmentProof that are meant to do the same thing

@Wondertan Wondertan reopened this Sep 17, 2024
@renaynay
Copy link
Member

Please rename the issue then so it's more clear @Wondertan

@Wondertan Wondertan changed the title fix GetProof to return the blob proof blob: Unify GetProof and GetCommitmentProof Sep 17, 2024
@renaynay renaynay added v0.17.0 Intended for v0.17.0 release and removed v0.15.0 labels Oct 2, 2024
@rach-id rach-id linked a pull request Oct 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
external Issues created by non node team members v0.17.0 Intended for v0.17.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: unify the blob.Proof and the CommitmentProof rach-id/celestia-node
3 participants
@Wondertan @rach-id @renaynay