Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

das: Retry getting header in catch-up routine a few times before failing out #547

Closed
renaynay opened this issue Mar 24, 2022 · 2 comments
Closed
Labels
area:shares Shares and samples

Comments

@renaynay
Copy link
Member

renaynay commented Mar 24, 2022

Retry getting header at given height inside catchUp a few times (maybe 3?) before failing out entirely.

Alternative would be to retry the header a few times before giving up. But could be done in a separate PR.

Originally posted by @liamsi in #473 (comment)

@renaynay renaynay added the area:shares Shares and samples label Mar 24, 2022
@renaynay renaynay moved this to TODO in Celestia Node Mar 24, 2022
@Wondertan
Copy link
Member

Wondertan commented Mar 24, 2022

For context:
image

@Wondertan
Copy link
Member

Wondertan commented Mar 24, 2022

But, there is no point to retry getting headers stored locally. We reliably know if we have it or if don't.

Even in the case where we fetch headers from the network via HeaderExchange, it should retry on its own, not the user(DASer) of should implement the retry. So I am closing this issue, see #497 which mentions retries for HeaderExchange.

In general, I doubt the idea of requesting single headers by height and not by hash(as we do here), because we cannot verify them, so even the idea of requesting headers here over the net does not seem to be valid.

This is not the case if we would stick to backward syncing/always identify headers by hash approach

Repository owner moved this from TODO to Done in Celestia Node Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:shares Shares and samples
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants