Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move default configuration settings to the app #151

Open
evan-forbes opened this issue May 25, 2022 · 2 comments
Open

Move default configuration settings to the app #151

evan-forbes opened this issue May 25, 2022 · 2 comments
Labels
C: app Changes related to the celestia-app branches

Comments

@evan-forbes
Copy link
Member

Currently we are overriding a few default configurations during the init command. We should move this to the app so that the settings we change are more explicit and don't require changes to the sdk.

@liamsi
Copy link
Member

liamsi commented May 26, 2022

Yeah, I was also confused about this. Either these default param changes can be made directly in core, or, in app. App is the best if feasible 👍🏼

@rootulp
Copy link
Collaborator

rootulp commented Nov 16, 2023

I think most of the default overrides have been moved to celestia-app's default_overrides.go. I think the remaining revertable overrides that can be moved to celestia-app are documented here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: app Changes related to the celestia-app branches
Projects
No open projects
Status: TODO
Development

No branches or pull requests

3 participants