Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove modifications that may be revertable #362

Open
rootulp opened this issue Dec 8, 2023 · 0 comments
Open

Remove modifications that may be revertable #362

rootulp opened this issue Dec 8, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@rootulp
Copy link
Collaborator

rootulp commented Dec 8, 2023

Context

While updating the README to describe the rationale for this fork, I noticed a few divergences between this repo and upstream cosmos/cosmos-sdk that I think may be revertable.

Proposal

  1. Investigate these modifications and determine if they are revertable or can be moved to celestia-app:

    cosmos-sdk/README.md

    Lines 26 to 34 in bc89c06

    Modifications that may be revertable:
    1. Override the default keyringBackend from `os` to `test`. Maybe move to celestia-app
    1. Increase `DefaultGasLimit` from 200000 to 210000.
    1. Remove `Evidence` from grpc/tmservice/types.pb.go.
    1. Override simapp test helpers `DefaultGenTxGas` from 10000000 to 2600000.
    1. Disable staticcheck golangci lint after fixing lint errors.
    1. In auth/tx/query.go disable the prove flag when querying transactions
    1. In server/util.go remove `conf.Consensus.TimeoutCommit = 5 * time.Second`
  2. Revert / move to celestia-app
  3. Remove the list from the README
@rootulp rootulp added the good first issue Good for newcomers label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant