Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block list misinterpretation results in overblocking #1713

Closed
boernsen-development opened this issue Sep 24, 2024 · 2 comments
Closed

Block list misinterpretation results in overblocking #1713

boernsen-development opened this issue Sep 24, 2024 · 2 comments

Comments

@boernsen-development
Copy link

boernsen-development commented Sep 24, 2024

Reproduce:

Expected:

  • Website loads, rain radar is shown
  • Tried this with Mull + uBlock Origin + the EasyPrivacy block list from above imported into uBlock (while the same block list was disabled in RethinkDNS) and the website fully loads

Actual:

  • Website doesn't load. In the log you can see several *.wo-cloud.com requests getting blocked.
  • To confirm: This happens once I enable the EasyPrivacy block list in RethinkDNS and does not if it is deactivated (even when using the exact same block list in uBlock Origin)

Presumed reason:
The block list includes only one related entry:

  • ||wo-cloud.com^$ping

I assume the ping option of this entry is misinterpreted and incorrectly blocks the entire domain.

Workaround:
Trusting the individual domains sometimes helps, but sometimes doesn't. Sometimes the request appears in the log as maybe blocked, which I don't know the meaning of.

I'm not familiar with block list syntax, but the related ping type option is described here: https://help.adblockplus.org/hc/en-us/articles/360062733293-How-to-write-filters#type-options

Suggested change:

  • Preferably correct block list's options interpretation (if at all possible, I'm not familiar with this)
  • Alternatively remove domains with such options from blocking to avoid overblocking

Maybe someone with experience can add to this. I am very happy to answer any questions as I love the idea of RethinkDNS and would like to support it!

@boernsen-development boernsen-development changed the title Block list's advanced filter option seems to be ignored Block list misinterpretation results in overblocking Sep 29, 2024
@ignoramous
Copy link
Collaborator

Thanks for the detailed bug report.

Rethink uses adp rules for just DNS-based content blocking. It doesn't yet implement HTTPS interception (like AdGuard does via either plugins or firewalls) to apply abp rules.

Also, the conversion of abp rules to domain rules is not fool-proof: serverless-dns/blocklists#48

In short, we prefer using domains/hosts files not abp

@boernsen-development
Copy link
Author

Thanks for your reply!

So, this is already in your pipeline :)
I didn't find the issue linked by you when researching prior to posting this. Sorry about that. I'm gonna close this issue as duplicate then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants