Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing 'thinlinc_server_bundle' 'breaks' project organization #42

Closed
Thulium-Drake opened this issue Sep 9, 2024 · 3 comments · Fixed by #43
Closed

Removing 'thinlinc_server_bundle' 'breaks' project organization #42

Thulium-Drake opened this issue Sep 9, 2024 · 3 comments · Fixed by #43
Assignees

Comments

@Thulium-Drake
Copy link
Contributor

Hi there,

In fad51d0 the thinlinc_server_bundle variable was removed, which allowed to place the zip file with the Thinlinc software in a custom location inside the playbooks/files folder (in my case playbooks/files/thinlinc as I have lots of files for different purposes that I distribute)

However, now I 'must' place the zip file in the top dir.

Can you please revert this? As it removes flexibility in where files can be stored.

@samhed
Copy link
Member

samhed commented Sep 10, 2024

Thanks for sharing your use case. I think we didn't consider the fact that you might use it for that purpose.

Would you mind having a look at this @aeneby? Do you think it would be a good idea to have an optional parameter for a directory in which to look for the server-zip?

@aeneby
Copy link

aeneby commented Sep 10, 2024

I think that's a reasonable request. We should probably have an optional parameter for the whole path (including filename) though, with a sensible default if not specified. Otherwise the next issue is going to be from someone wanting to rename the server bundle to something else.

@samhed assign to me if you like, I'll have a look.

@samhed
Copy link
Member

samhed commented Sep 10, 2024

Good thinking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants