Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

all: consider removing ExporterOption #20

Open
rakyll opened this issue Oct 10, 2018 · 0 comments
Open

all: consider removing ExporterOption #20

rakyll opened this issue Oct 10, 2018 · 0 comments

Comments

@rakyll
Copy link

rakyll commented Oct 10, 2018

Functional options are a considered disadvantageous due their complexity, read https://middlemost.com/object-lifecycle/ for more and consider about exporting some fields on the Exporter type instead.

type Exporter struct {
     Addr string
     Insecure bool
     ServiceName string
}

func NewExporter(serviceName string) (*Exporter, error) 
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants