Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

spans are lost when connection to collector endpoint resets #41

Open
rghetia opened this issue Jan 17, 2019 · 2 comments
Open

spans are lost when connection to collector endpoint resets #41

rghetia opened this issue Jan 17, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@rghetia
Copy link
Contributor

rghetia commented Jan 17, 2019

For interoperability test OC-Agent is used to send spans to test-coordinator. If test-coordinator is restarted then then a new tcp connection is established and the old one is in TIME_WAIT state. There is a period of time for which spans are lost even though the new connection is in ESTABLISHED state.

When then old connection is removed entirely then spans resume.

@rghetia rghetia changed the title spans are lost when connect to collector endpoint resets spans are lost when connection to collector endpoint resets Jan 17, 2019
@songy23 songy23 added the bug Something isn't working label Jan 17, 2019
@songy23
Copy link
Contributor

songy23 commented Jan 17, 2019

/cc @odeke-em

@odeke-em
Copy link
Contributor

Thank you for reporting this issue @rghetia and @songy23 for the ping!

Currently we use a bundler with a wait time as well when buffering spans to sends, but let's also ensure that on failed connection that we put spans into some sort of storage e.g. a circular buffer and send them once reconnection happens!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants