This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
quickstart/{java, go}/metrics: Add tags for "status" and "error" #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeke-em
reviewed
Nov 28, 2018
content/quickstart/go/metrics.md
Outdated
| @@ -406,15 +401,17 @@ Now we will insert a specific tag called "repl". It will give us a new `context. | |||
|
|
|||
| For example | |||
| ```go | |||
| ctx, err := tag.New(context.Background(), tag.Insert(KeyMethod, "repl")) | |||
| ctx, _ := tag.New(context.Background(), tag.Insert(KeyMethod, "repl"), | |||
There was a problem hiding this comment.
Please run these Go snippets through go-fmt first.
odeke-em
reviewed
Nov 28, 2018
content/quickstart/go/metrics.md
Outdated
| func readEvaluateProcess(br *bufio.Reader) error { | ||
| ctx, err := tag.New(context.Background(), tag.Insert(KeyMethod, "repl")) | ||
| func readEvaluateProcess(br *bufio.Reader) (terr error) { | ||
| ctx, _ := tag.New(context.Background(), tag.Insert(KeyMethod, "repl"), |
|
@odeke-em indentation fixed in latest commit. I also added a bit of noise to the PR by switching from shortcodes to backticks Update: Upon further inspection, my editor is still not respecting correct indentation (8 spaces per tab). I'm looking into it. In the meantime, here is a fun photo showcasing correct indentation in the editor, but no change in the file itself. Contents were copied and formatted directly from the Go Playground: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #470
Part 1 of 2 pull request to reduce cognitive load as reviewing quickstarts is no simple task.
This PR does the following for Go & Java Metric quickstarts:
readEvaluateProcessLinein a latency measurement to catch errors