Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets page: Redesign #2507

Open
sonam-jo opened this issue Oct 17, 2024 · 20 comments
Open

Assets page: Redesign #2507

sonam-jo opened this issue Oct 17, 2024 · 20 comments
Assignees

Comments

@sonam-jo
Copy link

ISSUER
Figma: https://www.figma.com/design/ng7qdNcSCXSDA6ZUdWIs6u/Pool-Overview%2F-Pool-Detail?node-id=4014-9891&node-type=canvas&t=u3aSuQHrPp2lwwer-0

Summary box on the top

  • Total Nav
  • Onchain reserve that can be clicked to a new page >
  • Offchain reserve with a drop down option. The drop down shows the list of all offchain accounts that can be clicked to a new page >
  • CTA to Create assets

Assets table

  • CTA to View asset transactions that will direct to Asset transactions pre selected on the Data tab
  • CTA Download
  • See changes in the columns for the table. Most of this data is already calculated for the Asset list on the Data tab. The new field is Portfolio % which is calculated as Market Value of the asset divided by the sum of market value of all assets. Portfolio % will be 0 for repaid assets.

Onchain reserve

  • Summary value on top
  • Chart with Amount values
  • Transaction history table (in the same format as the table in the Overview page)

Offchain reserve
For any of the offchain reserve accounts,

  • Summary value on top with CTA Deposit, Withdraw (primary) Charge fees, Correction (secondary)
  • Chart with Amount values
  • Transaction history table (in the same format as the table in the Overview page)

Asset detail page

  • Summary on top with Asset value, Price, Unrealized P&L (if the asset is not yet repaid/sold) or Realized P&L (if the asset has been repaid/sold) with CTA Finance/Purchase, Repay/Sell, Correction (depending on the type of asset)
  • In the Transaction history table, if the asset has been Repaid/sold, it should show Realized P&L. If the asset is not (ongoing, overdue etc), then the column should be Unrealized P&L. Currently we always show Realized P&L.
  • Rest of the details are same, just UI changes

Side panels for Issuer CTA

  • Actions are the same as today, only UI changes.
  • See change in text for the warning of Stablecoins which has been updated to: Stablecoins will be transferred to the designated withdrawal addresses on the specified networks. A delay may occur before the transfer is completed.
  • Also note that in addition to the pop-up that opens up today for Transaction pending or successful, we will also show Transaction pending/successful within the side panel.

INVESTOR
Figma: https://www.figma.com/design/ng7qdNcSCXSDA6ZUdWIs6u/Pool-Overview%2F-Pool-Detail?node-id=2521-1083&node-type=canvas&t=u3aSuQHrPp2lwwer-0

Same as Issuer but without any of the CTAs.

@sonam-jo sonam-jo changed the title Asset pages: Redesign Assets page: Redesign Oct 17, 2024
@kattylucy kattylucy mentioned this issue Oct 21, 2024
1 task
@0x4Graham
Copy link

image

^^ Table not having the responsive design. So on the screen it overflows and not possible to scroll to see. Only seems to be an issue on the bank account, transfer and broker account.

image Can we decrease the y axis scale on this? Let's not start at 0, Just to show better value increase

@0x4Graham
Copy link

Not sure if this is just an issue on the dev env, but getting this when looking at what fees to add.:

image

@0x4Graham
Copy link

image The dropdown calendar design is missing the same look and feel to the rest of the page

@0x4Graham
Copy link

Unable to create an asset after completing the fields?

image

@sonam-jo
Copy link
Author

Total assets should not be 0. It should be the sum of all the assets in the table underneath. And all the 3 fields in the box (onchain, offchain and total assets) should sum up to the total NAV

Screenshot 2024-10-30 at 11 05 01

@sonam-jo
Copy link
Author

Fields in the table do not match Figma.

  • We have Security type instead of Financing date
  • Quantity instead of Amount
  • Portfolio % is too far to the right. And there is too big a gap between Quantity and Market price

Screenshot 2024-10-30 at 11 07 04
Screenshot 2024-10-30 at 11 07 12

@sonam-jo
Copy link
Author

Chart is missing from Onchain reserve. View transaction column is cut off

Screenshot 2024-10-30 at 11 11 20
Screenshot 2024-10-30 at 11 11 27

@hieronx
Copy link
Contributor

hieronx commented Oct 30, 2024

Fields in the table do not match Figma.
We have Security type instead of Financing date

@kattylucy FYI Security type here is the list of key attributes from the asset template, see https://github.com/centrifuge/apps/blob/main/centrifuge-app/src/components/LoanList.tsx#L91 for how it is implemented now.

@sonam-jo
Copy link
Author

sonam-jo commented Oct 30, 2024

With all three offchain accounts

  • There is no data in the chart
  • It should be USD vs USDC for current value and in the chart
  • What is the pricing box on the page? That shouldn't be there I think
  • View transaction column is cut off

Screenshot 2024-10-30 at 11 13 10
Screenshot 2024-10-30 at 11 14 31

@sonam-jo
Copy link
Author

Currency denomination is in the title, not next to the number

Screenshot 2024-10-30 at 11 19 18
Screenshot 2024-10-30 at 11 19 24

@sonam-jo
Copy link
Author

Asset detail page is missing the Pricing box.
Also add more space/padding between the Price and Unrealized/Realized P&L in the box relative to Asset value - in line with Figma

Screenshot 2024-10-30 at 11 22 17
Screenshot 2024-10-30 at 11 25 02

@kattylucy
Copy link
Collaborator

Right now for the transaction table we have different values based on the pool type, either private or public. You are not seeing some of those values (like face value for example) because of the pool type. Are we changing this logic to show what the figma table is showing for all public & private, so, should I remove such logic? (Im not sure what is the difference tbd)

@sonam-jo

@sonam-jo
Copy link
Author

@kattylucy I don't see any changes required for the Transaction history table on the Asset detail page. Those fields can be the same as they are today. As long as the data is coming through, as we have in the app today. Not sure what logic you are referring to?

@kattylucy
Copy link
Collaborator

No, you are right. I was looking at the wrong table @sonam-jo

@sonam-jo
Copy link
Author

  • Onchain reserve should be USDC
  • Can remove Price from these charts
  • Could still move price and Unrealized/Realized P&L more to the right and have more space between the fields

Screenshot 2024-10-31 at 16 52 43
Screenshot 2024-10-31 at 16 54 28
Screenshot 2024-10-31 at 16 55 22

@BrianCarter-Design
Copy link
Collaborator

Hi @kattylucy,
Here is a link to the QA I've done:
https://www.figma.com/design/ng7qdNcSCXSDA6ZUdWIs6u?node-id=4516-1302#1009907355

Much less feedback than on the previous pages, so I think the styles are mostly correct in production now.
Well done.

@sonam-jo
Copy link
Author

sonam-jo commented Nov 1, 2024

A few new changes since the original design. These are also reflected in Figma now.

For both Investor and Issuer view, can we please:

  • Add Accrued fees to the box on the top always with a "-" minus sign? We need to make sure that Total NAV = Onchain reserve + Offchain cash + Total assets - Accrued fees (so the numbers need to add up correctly)
  • Create a hover state for Onchain reserve and Offchain cash with an underline (similar to what we do with Pool analysis on the Overview page) so its obvious that these fields are clickable
  • Change the title of the table to X ongoing assets where we calculate the number of ongoing assets

Screenshot 2024-11-01 at 15 22 07

@hieronx
Copy link
Contributor

hieronx commented Nov 6, 2024

A few post-launch minor feedback points:

Accrued fees should show as 0 rather than -0 if zero:

Screenshot 2024-11-06 at 20 42 00

Sell button (same for Purchase/Finance/Repay) should be primary:

Screenshot 2024-11-06 at 20 43 40

Unrelated to assets, but I think we need to widen the connect wallet button:

Screenshot 2024-11-06 at 20 44 02

The margin near the heading, as well as the padding within the card, and the margin between the grey and white cards, is off compared to design:

Screenshot 2024-11-06 at 20 45 41

vs

image

@sonam-jo
Copy link
Author

sonam-jo commented Nov 11, 2024

Only count the ongoing assets that still have a portfolio weighting, not all assets. it should be 6 ongoing assets

Image

@sonam-jo
Copy link
Author

Can we please add the total amount for each of the offchain accounts within the dropdown so the user can see the values without having to click on each?
Also the ) after USD is missing

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants