-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli, api: usability improvements #518
Comments
@epuertat uuid is not a required parameter in any namespace command. If the user doesn't supply it one will be generated for him. We still allow to use in namespace commands as the namespace identifier. If the user find it unfriendly he can totally ignore it. There is no need to remove it from gRPC. People using API and not the CLI might find it usefull |
gbregman
added a commit
to gbregman/ceph-nvmeof
that referenced
this issue
Mar 31, 2024
Fixes ceph#518 Signed-off-by: Gil Bregman <[email protected]>
gbregman
added a commit
to gbregman/ceph-nvmeof
that referenced
this issue
Mar 31, 2024
Fixes ceph#518 Signed-off-by: Gil Bregman <[email protected]>
gbregman
added a commit
to gbregman/ceph-nvmeof
that referenced
this issue
Mar 31, 2024
Fixes ceph#518 Signed-off-by: Gil Bregman <[email protected]>
gbregman
added a commit
to gbregman/ceph-nvmeof
that referenced
this issue
Mar 31, 2024
Fixes ceph#518 Signed-off-by: Gil Bregman <[email protected]>
gbregman
added a commit
to gbregman/ceph-nvmeof
that referenced
this issue
Mar 31, 2024
Fixes ceph#518 Signed-off-by: Gil Bregman <[email protected]>
gbregman
added a commit
to gbregman/ceph-nvmeof
that referenced
this issue
Mar 31, 2024
Fixes ceph#518 Signed-off-by: Gil Bregman <[email protected]>
gbregman
added a commit
to gbregman/ceph-nvmeof
that referenced
this issue
Mar 31, 2024
Fixes ceph#518 Signed-off-by: Gil Bregman <[email protected]>
gbregman
added a commit
to gbregman/ceph-nvmeof
that referenced
this issue
Mar 31, 2024
Fixes ceph#518 Signed-off-by: Gil Bregman <[email protected]>
gbregman
added a commit
to gbregman/ceph-nvmeof
that referenced
this issue
Apr 1, 2024
Fixes ceph#518 Signed-off-by: Gil Bregman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Few suggestions on usability:
subsystem_nqn
,subsystem
andnqn
.anagrpid
,load_balancing_group
(are they the same thing?).namespace_add
(which is consistent with CLI), butlist_namespaces
. All methods should adopt the same convention, preferably<object>_<verb>
.uuid
really required? Compared to havingnsid
(indexes, like 1, 2, 3...), it looks like a unfriendly param. That's ok for metadata, but most namespace calls accept optionallyuuid
andnsid
.Tasks
The text was updated successfully, but these errors were encountered: